Patchwork [3/4] pci: add creation functions that may fail

login
register
mail settings
Submitter Blue Swirl
Date Feb. 2, 2011, 6:27 p.m.
Message ID <AANLkTi=NVMfiaznfLAOQhjKpzGEderDA1r6xDjtxAkJ3@mail.gmail.com>
Download mbox | patch
Permalink /patch/81527/
State New
Headers show

Comments

Blue Swirl - Feb. 2, 2011, 6:27 p.m.
Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
---
 hw/pci.c |   20 ++++++++++++++++++++
 hw/pci.h |    4 ++++
 2 files changed, 24 insertions(+), 0 deletions(-)

 {

Patch

diff --git a/hw/pci.c b/hw/pci.c
index d5bbba9..5e6e216 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -1708,6 +1708,21 @@  PCIDevice *pci_create_multifunction(PCIBus
*bus, int devfn, bool multifunction,
     return DO_UPCAST(PCIDevice, qdev, dev);
 }

+PCIDevice *pci_try_create_multifunction(PCIBus *bus, int devfn,
+                                        bool multifunction,
+                                        const char *name)
+{
+    DeviceState *dev;
+
+    dev = qdev_try_create(&bus->qbus, name);
+    if (!dev) {
+        return NULL;
+    }
+    qdev_prop_set_uint32(dev, "addr", devfn);
+    qdev_prop_set_bit(dev, "multifunction", multifunction);
+    return DO_UPCAST(PCIDevice, qdev, dev);
+}
+
 PCIDevice *pci_create_simple_multifunction(PCIBus *bus, int devfn,
                                            bool multifunction,
                                            const char *name)
@@ -1727,6 +1742,11 @@  PCIDevice *pci_create_simple(PCIBus *bus, int
devfn, const char *name)
     return pci_create_simple_multifunction(bus, devfn, false, name);
 }

+PCIDevice *pci_try_create(PCIBus *bus, int devfn, const char *name)
+{
+    return pci_try_create_multifunction(bus, devfn, false, name);
+}
+
 static int pci_find_space(PCIDevice *pdev, uint8_t size)
 {
     int config_size = pci_config_size(pdev);
diff --git a/hw/pci.h b/hw/pci.h
index 0d2753f..113e556 100644
--- a/hw/pci.h
+++ b/hw/pci.h
@@ -453,8 +453,12 @@  PCIDevice *pci_create_multifunction(PCIBus *bus,
int devfn, bool multifunction,
 PCIDevice *pci_create_simple_multifunction(PCIBus *bus, int devfn,
                                            bool multifunction,
                                            const char *name);
+PCIDevice *pci_try_create_multifunction(PCIBus *bus, int devfn,
+                                        bool multifunction,
+                                        const char *name);
 PCIDevice *pci_create(PCIBus *bus, int devfn, const char *name);
 PCIDevice *pci_create_simple(PCIBus *bus, int devfn, const char *name);
+PCIDevice *pci_try_create(PCIBus *bus, int devfn, const char *name);

 static inline int pci_is_express(const PCIDevice *d)