From patchwork Wed Feb 2 18:58:18 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tim Gardner X-Patchwork-Id: 81514 X-Patchwork-Delegate: stefan.bader@canonical.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from chlorine.canonical.com (chlorine.canonical.com [91.189.94.204]) by ozlabs.org (Postfix) with ESMTP id BC7ACB70EA for ; Thu, 3 Feb 2011 05:58:36 +1100 (EST) Received: from localhost ([127.0.0.1] helo=chlorine.canonical.com) by chlorine.canonical.com with esmtp (Exim 4.71) (envelope-from ) id 1PkhuL-0008Md-3A; Wed, 02 Feb 2011 18:58:25 +0000 Received: from mail.tpi.com ([70.99.223.143]) by chlorine.canonical.com with esmtp (Exim 4.71) (envelope-from ) id 1PkhuI-0008MM-Jg for kernel-team@lists.ubuntu.com; Wed, 02 Feb 2011 18:58:22 +0000 Received: from sepang.rtg.net (unknown [10.0.2.5]) by mail.tpi.com (Postfix) with ESMTP id 4756A299B5D for ; Wed, 2 Feb 2011 10:58:04 -0800 (PST) Received: by sepang.rtg.net (Postfix, from userid 1000) id 1A7FBF89F8; Wed, 2 Feb 2011 11:58:18 -0700 (MST) To: kernel-team@lists.ubuntu.com Subject: Maverick CVE-2010-3880, inet_diag: Make sure we actually run the same bytecode we audited Message-Id: <20110202185818.1A7FBF89F8@sepang.rtg.net> Date: Wed, 2 Feb 2011 11:58:18 -0700 (MST) From: timg@tpi.com (Tim Gardner) X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.13 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: kernel-team-bounces@lists.ubuntu.com Errors-To: kernel-team-bounces@lists.ubuntu.com The following changes since commit 8c8177a53331b2c0a49df5ca4b44e4700ad550e8: Kulikov Vasiliy (1): net: tipc: fix information leak to userland, CVE-2010-3877 are available in the git repository at: git://kernel.ubuntu.com/rtg/ubuntu-maverick.git CVE-2010-3880 Nelson Elhage (1): inet_diag: Make sure we actually run the same bytecode we audited, CVE-2010-3880 net/ipv4/inet_diag.c | 27 ++++++++++++++++----------- 1 files changed, 16 insertions(+), 11 deletions(-) From fc7762049ad234ce6e790a3b68528928521af63e Mon Sep 17 00:00:00 2001 From: Nelson Elhage Date: Wed, 3 Nov 2010 16:35:41 +0000 Subject: [PATCH] inet_diag: Make sure we actually run the same bytecode we audited, CVE-2010-3880 BugLink: http://bugs.launchpad.net/bugs/711865 CVE-2010-3880 We were using nlmsg_find_attr() to look up the bytecode by attribute when auditing, but then just using the first attribute when actually running bytecode. So, if we received a message with two attribute elements, where only the second had type INET_DIAG_REQ_BYTECODE, we would validate and run different bytecode strings. Fix this by consistently using nlmsg_find_attr everywhere. Signed-off-by: Nelson Elhage Signed-off-by: Thomas Graf Signed-off-by: David S. Miller (cherry picked from commit 22e76c849d505d87c5ecf3d3e6742a65f0ff4860) Signed-off-by: Tim Gardner Acked-by: Stefan Bader Acked-by: Brad Figg --- net/ipv4/inet_diag.c | 27 ++++++++++++++++----------- 1 files changed, 16 insertions(+), 11 deletions(-)