[v4,1/2] wire: export w1_touch_bit

Message ID 20170918130346.3886-1-jjj@gmx.de
State Superseded
Headers show
Series
  • [v4,1/2] wire: export w1_touch_bit
Related show

Commit Message

Jan Kandziora Sept. 18, 2017, 1:03 p.m.
The w1_ds28e17 driver from the next part of this patch needs to emit
single-bit read timeslots to the DS28E17. The w1 subsystem already
has this function but it is not exported outside drivers/w1/w1_io.c

This subpatch exports the w1_touch_bit symbol with EXPORT_SYMBOL_GPL,
same as the other exported symbols in drivers/w1/w1_io.c

May be also useful later for writing drivers for other Onewire chips
which do single-bit communication.

Signed-off-by: Jan Kandziora <jjj@gmx.de>
---
Changes in v4 against v3 in this subpatch:
  - adapted to linux-4.12.0

No changes in v3 against v2,v1 in this subpatch.

 drivers/w1/w1.h    | 1 +
 drivers/w1/w1_io.c | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

Comments

Greg KH Sept. 18, 2017, 2:19 p.m. | #1
On Mon, Sep 18, 2017 at 03:03:45PM +0200, Jan Kandziora wrote:
> The w1_ds28e17 driver from the next part of this patch needs to emit
> single-bit read timeslots to the DS28E17. The w1 subsystem already
> has this function but it is not exported outside drivers/w1/w1_io.c
> 
> This subpatch exports the w1_touch_bit symbol with EXPORT_SYMBOL_GPL,
> same as the other exported symbols in drivers/w1/w1_io.c
> 
> May be also useful later for writing drivers for other Onewire chips
> which do single-bit communication.
> 
> Signed-off-by: Jan Kandziora <jjj@gmx.de>
> Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
> ---
> Changes in v4 against v3 in this subpatch:
>   - adapted to linux-4.12.0
> 
> No changes in v3 against v2,v1 in this subpatch.

You should change it as it does not apply to 4.14-rc1 :(

Please rebase your patches and resend them, with Evgeniy's acks added to
them.

thanks,

greg k-h
Jan Kandziora Sept. 18, 2017, 7:34 p.m. | #2
Am 18.09.2017 um 16:19 schrieb GregKH:
> On Mon, Sep 18, 2017 at 03:03:45PM +0200, Jan Kandziora wrote:
>> The w1_ds28e17 driver from the next part of this patch needs to emit
>> single-bit read timeslots to the DS28E17. The w1 subsystem already
>> has this function but it is not exported outside drivers/w1/w1_io.c
>>
>> This subpatch exports the w1_touch_bit symbol with EXPORT_SYMBOL_GPL,
>> same as the other exported symbols in drivers/w1/w1_io.c
>>
>> May be also useful later for writing drivers for other Onewire chips
>> which do single-bit communication.
>>
>> Signed-off-by: Jan Kandziora <jjj@gmx.de>
>> Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
>> ---
>> Changes in v4 against v3 in this subpatch:
>>   - adapted to linux-4.12.0
>>
>> No changes in v3 against v2,v1 in this subpatch.
> 
> You should change it as it does not apply to 4.14-rc1 :(
> 
Okay, I will review them again.


> Please rebase your patches and resend them, with Evgeniy's acks added to
> them.
> 
Now you caught me. I don't know how to do that. What's required? The
Acked-by: line? Am I allowed to simply add these lines to my patches or
is there a procedure to follow?

Kind regards

	Jan
Greg KH Sept. 18, 2017, 7:37 p.m. | #3
On Mon, Sep 18, 2017 at 09:34:27PM +0200, Jan Kandziora wrote:
> Am 18.09.2017 um 16:19 schrieb GregKH:
> > On Mon, Sep 18, 2017 at 03:03:45PM +0200, Jan Kandziora wrote:
> >> The w1_ds28e17 driver from the next part of this patch needs to emit
> >> single-bit read timeslots to the DS28E17. The w1 subsystem already
> >> has this function but it is not exported outside drivers/w1/w1_io.c
> >>
> >> This subpatch exports the w1_touch_bit symbol with EXPORT_SYMBOL_GPL,
> >> same as the other exported symbols in drivers/w1/w1_io.c
> >>
> >> May be also useful later for writing drivers for other Onewire chips
> >> which do single-bit communication.
> >>
> >> Signed-off-by: Jan Kandziora <jjj@gmx.de>
> >> Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
> >> ---
> >> Changes in v4 against v3 in this subpatch:
> >>   - adapted to linux-4.12.0
> >>
> >> No changes in v3 against v2,v1 in this subpatch.
> > 
> > You should change it as it does not apply to 4.14-rc1 :(
> > 
> Okay, I will review them again.
> 
> 
> > Please rebase your patches and resend them, with Evgeniy's acks added to
> > them.
> > 
> Now you caught me. I don't know how to do that. What's required? The
> Acked-by: line? Am I allowed to simply add these lines to my patches or
> is there a procedure to follow?

Just add the acked-by line, like I did above, and all should be fine.

thanks,

greg k-h
Jan Kandziora Sept. 20, 2017, 9:54 p.m. | #4
Am 18.09.2017 um 16:19 schrieb GregKH:
> On Mon, Sep 18, 2017 at 03:03:45PM +0200, Jan Kandziora wrote:
>> The w1_ds28e17 driver from the next part of this patch needs to emit
>> single-bit read timeslots to the DS28E17. The w1 subsystem already
>> has this function but it is not exported outside drivers/w1/w1_io.c
>>
>> This subpatch exports the w1_touch_bit symbol with EXPORT_SYMBOL_GPL,
>> same as the other exported symbols in drivers/w1/w1_io.c
>>
>> May be also useful later for writing drivers for other Onewire chips
>> which do single-bit communication.
>>
>> Signed-off-by: Jan Kandziora <jjj@gmx.de>
>> Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
>> ---
>> Changes in v4 against v3 in this subpatch:
>>   - adapted to linux-4.12.0
>>
>> No changes in v3 against v2,v1 in this subpatch.
> 
> You should change it as it does not apply to 4.14-rc1 :(
> 
I revised it and just sent it to you and now I hope for the best.

Kind regards

	Jan

Patch

diff --git a/drivers/w1/w1.h b/drivers/w1/w1.h
index 758a7a6..e7af855 100644
--- a/drivers/w1/w1.h
+++ b/drivers/w1/w1.h
@@ -295,6 +295,7 @@  int w1_attach_slave_device(struct w1_master *dev, struct w1_reg_num *rn);
 int w1_slave_detach(struct w1_slave *sl);
 
 u8 w1_triplet(struct w1_master *dev, int bdir);
+u8 w1_touch_bit(struct w1_master *dev, int bit);
 void w1_write_8(struct w1_master *, u8);
 u8 w1_read_8(struct w1_master *);
 int w1_reset_bus(struct w1_master *);
diff --git a/drivers/w1/w1_io.c b/drivers/w1/w1_io.c
index 1134e6b..4bb77a1 100644
--- a/drivers/w1/w1_io.c
+++ b/drivers/w1/w1_io.c
@@ -58,7 +58,7 @@  static u8 w1_read_bit(struct w1_master *dev);
  * @dev:	the master device
  * @bit:	0 - write a 0, 1 - write a 0 read the level
  */
-static u8 w1_touch_bit(struct w1_master *dev, int bit)
+u8 w1_touch_bit(struct w1_master *dev, int bit)
 {
 	if (dev->bus_master->touch_bit)
 		return dev->bus_master->touch_bit(dev->bus_master->data, bit);
@@ -69,6 +69,7 @@  static u8 w1_touch_bit(struct w1_master *dev, int bit)
 		return 0;
 	}
 }
+EXPORT_SYMBOL_GPL(w1_touch_bit);
 
 /**
  * w1_write_bit() - Generates a write-0 or write-1 cycle.