| Message ID | 20170917225927.117917-6-sjg@chromium.org |
|---|---|
| State | Superseded |
| Delegated to: | Alexander Graf |
| Headers | show |
| Series | efi: Enable basic sandbox support for EFI loader | expand |
On 09/18/2017 12:59 AM, Simon Glass wrote: > The headers are not in the correct order. Fix this. The commit message should tell that and explain why you are dropping #include <libfdt_env.h> > > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > > lib/efi_loader/efi_memory.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/lib/efi_loader/efi_memory.c b/lib/efi_loader/efi_memory.c > index 9e079f1fa3..ad3d277be6 100644 > --- a/lib/efi_loader/efi_memory.c > +++ b/lib/efi_loader/efi_memory.c > @@ -8,12 +8,11 @@ > > #include <common.h> > #include <efi_loader.h> > +#include <inttypes.h> > #include <malloc.h> > +#include <watchdog.h> > #include <asm/global_data.h> > -#include <libfdt_env.h> > #include <linux/list_sort.h> > -#include <inttypes.h> > -#include <watchdog.h> > > DECLARE_GLOBAL_DATA_PTR; > >
diff --git a/lib/efi_loader/efi_memory.c b/lib/efi_loader/efi_memory.c index 9e079f1fa3..ad3d277be6 100644 --- a/lib/efi_loader/efi_memory.c +++ b/lib/efi_loader/efi_memory.c @@ -8,12 +8,11 @@ #include <common.h> #include <efi_loader.h> +#include <inttypes.h> #include <malloc.h> +#include <watchdog.h> #include <asm/global_data.h> -#include <libfdt_env.h> #include <linux/list_sort.h> -#include <inttypes.h> -#include <watchdog.h> DECLARE_GLOBAL_DATA_PTR;
The headers are not in the correct order. Fix this. Signed-off-by: Simon Glass <sjg@chromium.org> --- lib/efi_loader/efi_memory.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)