sound: tegra20-spdif: remove "default m"

Message ID c765842d4cc6af91ae0d6977922e6ae6f6e1dfa8.1505661134.git.mirq-linux@rere.qmqm.pl
State New
Headers show
Series
  • sound: tegra20-spdif: remove "default m"
Related show

Commit Message

Michał Mirosław Sept. 17, 2017, 3:15 p.m.
Default != n for drivers is frowned upon. This is the only one among
tegra sound drivers that was different.

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
---
 sound/soc/tegra/Kconfig | 1 -
 1 file changed, 1 deletion(-)

Comments

Dmitry Osipenko Sept. 25, 2017, 8:37 p.m. | #1
On 17.09.2017 18:15, Michał Mirosław wrote:
> Default != n for drivers is frowned upon. This is the only one among
> tegra sound drivers that was different.
> 
> Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
> ---
>  sound/soc/tegra/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/sound/soc/tegra/Kconfig b/sound/soc/tegra/Kconfig
> index 6875fc39a575..6c893c677110 100644
> --- a/sound/soc/tegra/Kconfig
> +++ b/sound/soc/tegra/Kconfig
> @@ -38,7 +38,6 @@ config SND_SOC_TEGRA20_I2S
>  config SND_SOC_TEGRA20_SPDIF
>  	tristate "Tegra20 SPDIF interface"
>  	depends on SND_SOC_TEGRA
> -	default m
>  	help
>  	  Say Y or M if you want to add support for the Tegra20 SPDIF interface.
>  	  You will also need to select the individual machine drivers to support
> 

IIUC this driver should be integrated with the Tegra DRM to be useful. Making it
built-in by default would just increase kernels size.

Patch

diff --git a/sound/soc/tegra/Kconfig b/sound/soc/tegra/Kconfig
index 6875fc39a575..6c893c677110 100644
--- a/sound/soc/tegra/Kconfig
+++ b/sound/soc/tegra/Kconfig
@@ -38,7 +38,6 @@  config SND_SOC_TEGRA20_I2S
 config SND_SOC_TEGRA20_SPDIF
 	tristate "Tegra20 SPDIF interface"
 	depends on SND_SOC_TEGRA
-	default m
 	help
 	  Say Y or M if you want to add support for the Tegra20 SPDIF interface.
 	  You will also need to select the individual machine drivers to support