diff mbox series

[U-Boot,04/13] mtdparts: Correct use of debug()

Message ID 20170916212331.170463-5-sjg@chromium.org
State Superseded
Delegated to: Simon Glass
Headers show
Series log: Add a new logging feature | expand

Commit Message

Simon Glass Sept. 16, 2017, 9:23 p.m. UTC 
The debug() macro now evaluates its expression so does not need #ifdef
protection. In fact the current code causes a warning with the new log
implementation. Adjust the code to fix this.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

 cmd/mtdparts.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Bin Meng Sept. 17, 2017, 12:54 p.m. UTC | #1 
On Sun, Sep 17, 2017 at 5:23 AM, Simon Glass <sjg@chromium.org> wrote:
> The debug() macro now evaluates its expression so does not need #ifdef
> protection. In fact the current code causes a warning with the new log
> implementation. Adjust the code to fix this.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
>  cmd/mtdparts.c | 3 ---
>  1 file changed, 3 deletions(-)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
diff mbox series

Patch

diff --git a/cmd/mtdparts.c b/cmd/mtdparts.c
index 3275eb919b..13677faf4b 100644
--- a/cmd/mtdparts.c
+++ b/cmd/mtdparts.c
@@ -873,15 +873,12 @@  static int device_parse(const char *const mtd_dev, const char **ret, struct mtd_
 		return 1;
 	}
 
-#ifdef DEBUG
 	pend = strchr(p, ';');
-#endif
 	debug("dev type = %d (%s), dev num = %d, mtd-id = %s\n",
 			id->type, MTD_DEV_TYPE(id->type),
 			id->num, id->mtd_id);
 	debug("parsing partitions %.*s\n", (int)(pend ? pend - p : strlen(p)), p);
 
-
 	/* parse partitions */
 	num_parts = 0;