Message ID | 1505503545-4113-2-git-send-email-jhugo@codeaurora.org |
---|---|
State | Accepted |
Headers | show |
Series | [V2,1/2] dmi: dmicheck: Fix Base Address Modifier checking | expand |
On 2017-09-15 12:25 PM, Jeffrey Hugo wrote: > The Intelligent Platform Management Interface (IPMI) Specification defines > BMC Interface Types in section C1-1.1. Type 4 is an addition in the IPMI > spec which does not appear in the SMBIOS spec, which means "SSIF: SMBus > System Interface". > > Add type 4 as a valid type to the test. > > Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org> > --- > src/dmi/dmicheck/dmicheck.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c > index 2e139ad..236edc6 100644 > --- a/src/dmi/dmicheck/dmicheck.c > +++ b/src/dmi/dmicheck/dmicheck.c > @@ -1768,7 +1768,7 @@ static void dmicheck_entry(fwts_framework *fw, > > case 38: /* 7.39 */ > table = "IPMI Device Information (Type 38)"; > - dmi_min_max_uint8_check(fw, table, addr, "Interface Type", hdr, 0x4, 0x0, 0x3); > + dmi_min_max_uint8_check(fw, table, addr, "Interface Type", hdr, 0x4, 0x0, 0x4); > > dmi_reserved_bits_check(fw, table, addr, "Base Addr Modifier/Interrupt Info", hdr, sizeof(uint8_t), 0x10, 2, 2); > dmi_reserved_bits_check(fw, table, addr, "Base Addr Modifier/Interrupt Info", hdr, sizeof(uint8_t), 0x10, 5, 5); > Acked-by: Alex Hung <alex.hung@canonical.com>
On 15/09/17 20:25, Jeffrey Hugo wrote: > The Intelligent Platform Management Interface (IPMI) Specification defines > BMC Interface Types in section C1-1.1. Type 4 is an addition in the IPMI > spec which does not appear in the SMBIOS spec, which means "SSIF: SMBus > System Interface". > > Add type 4 as a valid type to the test. > > Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org> > --- > src/dmi/dmicheck/dmicheck.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c > index 2e139ad..236edc6 100644 > --- a/src/dmi/dmicheck/dmicheck.c > +++ b/src/dmi/dmicheck/dmicheck.c > @@ -1768,7 +1768,7 @@ static void dmicheck_entry(fwts_framework *fw, > > case 38: /* 7.39 */ > table = "IPMI Device Information (Type 38)"; > - dmi_min_max_uint8_check(fw, table, addr, "Interface Type", hdr, 0x4, 0x0, 0x3); > + dmi_min_max_uint8_check(fw, table, addr, "Interface Type", hdr, 0x4, 0x0, 0x4); > > dmi_reserved_bits_check(fw, table, addr, "Base Addr Modifier/Interrupt Info", hdr, sizeof(uint8_t), 0x10, 2, 2); > dmi_reserved_bits_check(fw, table, addr, "Base Addr Modifier/Interrupt Info", hdr, sizeof(uint8_t), 0x10, 5, 5); > Thanks Jeffrey, Acked-by: Colin Ian King <colin.king@canonical.com>
diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c index 2e139ad..236edc6 100644 --- a/src/dmi/dmicheck/dmicheck.c +++ b/src/dmi/dmicheck/dmicheck.c @@ -1768,7 +1768,7 @@ static void dmicheck_entry(fwts_framework *fw, case 38: /* 7.39 */ table = "IPMI Device Information (Type 38)"; - dmi_min_max_uint8_check(fw, table, addr, "Interface Type", hdr, 0x4, 0x0, 0x3); + dmi_min_max_uint8_check(fw, table, addr, "Interface Type", hdr, 0x4, 0x0, 0x4); dmi_reserved_bits_check(fw, table, addr, "Base Addr Modifier/Interrupt Info", hdr, sizeof(uint8_t), 0x10, 2, 2); dmi_reserved_bits_check(fw, table, addr, "Base Addr Modifier/Interrupt Info", hdr, sizeof(uint8_t), 0x10, 5, 5);
The Intelligent Platform Management Interface (IPMI) Specification defines BMC Interface Types in section C1-1.1. Type 4 is an addition in the IPMI spec which does not appear in the SMBIOS spec, which means "SSIF: SMBus System Interface". Add type 4 as a valid type to the test. Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org> --- src/dmi/dmicheck/dmicheck.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)