From patchwork Fri Sep 15 14:04:07 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Romain Izard X-Patchwork-Id: 814283 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-pwm-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="OqgyhTsS"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3xtxxQ60lRz9s7m for ; Sat, 16 Sep 2017 00:05:14 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751701AbdIOOFN (ORCPT ); Fri, 15 Sep 2017 10:05:13 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:38301 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751651AbdIOOFJ (ORCPT ); Fri, 15 Sep 2017 10:05:09 -0400 Received: by mail-wm0-f66.google.com with SMTP id x17so2862548wmd.5; Fri, 15 Sep 2017 07:05:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=aaNnsNahYIjh+1Ks16UeHfn5wML1ytVR6uApSlam0ak=; b=OqgyhTsSOUMP1mVjyu/obvgk3bNOtKuna5CRZtg9kBCdhq7TnEgjhGITEIisIEQAW7 Mut/LLFCccw82cWRFBQRWeWN9egZpx86KwadjaGsCrevoyWSCp3nnrpQIIkbnEg5iVgz U6K7wLmk9ApCXK2EyUySCYTAPIuICMYbKpNGC2lqX6+lY/rJL0V1aZWkzZKaz1eYJdQ9 ryBJ+fI+RurDDJoy2zGUcUtN+PqZqmuT1zq4twvNm1r9GKLuMKycO5hzY6m2B7h5M1xl oUekFS6p52VqfHfHPARmjvjiVTDWbhmIRYdNhOYbu96axJ/Uh+UgpoyFKyMSbo1RtoRk /tbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=aaNnsNahYIjh+1Ks16UeHfn5wML1ytVR6uApSlam0ak=; b=Qjew6ZqGW5nPoOhOqNiygixGz6O5tEMLZsdJYG2uBexWb0vJ8ncvaDxAHfmXxmkZUv 0cesB6XVQT0cEXz9X1T7SDmDTH7tJnvnqExKIW1dl6sZ7m1Jj7VX8wY3U/SvKw7GGULY hUacfwRfdtAIkRM7BBFvXQ8u6Xa8PnoX5oNLY0RNv3FtP3UOw7iyJaihnZfVrL8drSSw 7YM6v5MBYTzcC4KB+4+MQAq+o9PoTJwYnn/lUQUa/2Oh8FxQBeJ63W2fA/6TwKF/4GGA ZBC359Ynsxd/M/JIU6Fjx/531A2QD3VJc84yHb31zRUEglPexEEuye2TjFt6uym5yLzp eRlg== X-Gm-Message-State: AHPjjUgF2X7qB33UImFXg14EzrKN7VySvHcm7o3aOQILIMImcxVKfImi tEAZ5H1/uDmFF6MRgiyHi/g= X-Google-Smtp-Source: AOwi7QBnCD+VHqUcD6q/tJCH+iN6CxlbVr6SP3fS133oqL63dNXiXTxV1nTYTt8BdvqglV3ugcBYFA== X-Received: by 10.28.30.133 with SMTP id e127mr2668086wme.8.1505484307983; Fri, 15 Sep 2017 07:05:07 -0700 (PDT) Received: from localhost.localdomain (146.187.3.109.rev.sfr.net. [109.3.187.146]) by smtp.gmail.com with ESMTPSA id 55sm1399225wrw.60.2017.09.15.07.04.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Sep 2017 07:05:07 -0700 (PDT) From: Romain Izard To: Nicolas Ferre , Alexandre Belloni , Boris Brezillon , Michael Turquette , Stephen Boyd , Ludovic Desroches , Wenyou Yang , Josh Wu , David Woodhouse , Brian Norris , Marek Vasut , Cyrille Pitchen , Thierry Reding , Richard Genoud , Greg Kroah-Hartman , Alan Stern Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, linux-pwm@vger.kernel.org, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Romain Izard Subject: [PATCH v2 5/9] mtd: nand: atmel: Report PMECC failures as errors Date: Fri, 15 Sep 2017 16:04:07 +0200 Message-Id: <20170915140411.31716-6-romain.izard.pro@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170915140411.31716-1-romain.izard.pro@gmail.com> References: <20170915140411.31716-1-romain.izard.pro@gmail.com> Sender: linux-pwm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org It is not normal for the PMECC to fail when trying to fix ECC errors. Report these cases as errors. Signed-off-by: Romain Izard --- drivers/mtd/nand/atmel/pmecc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/nand/atmel/pmecc.c b/drivers/mtd/nand/atmel/pmecc.c index 8d1208f38025..2a23f1ff945f 100644 --- a/drivers/mtd/nand/atmel/pmecc.c +++ b/drivers/mtd/nand/atmel/pmecc.c @@ -687,6 +687,8 @@ static int atmel_pmecc_err_location(struct atmel_pmecc_user *user) * Number of roots does not match the degree of smu * unable to correct error. */ + dev_err(pmecc->dev, + "PMECC: Impossible to calculate error location.\n"); return -EBADMSG; } @@ -729,7 +731,7 @@ int atmel_pmecc_correct_sector(struct atmel_pmecc_user *user, int sector, ptr = ecc + byte - sectorsize; area = "ECC"; } else { - dev_dbg(pmecc->dev, + dev_err(pmecc->dev, "Invalid errpos value (%d, max is %d)\n", errpos, (sectorsize + eccbytes) * 8); return -EINVAL;