| Message ID | 1505398720-4535-1-git-send-email-vladimir.barinov@cogentembedded.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | [v2,01/18] dt: arm: shmobile: add M3ULCB Kingfisher board DT bindings | expand |
Hi Vladimir, On Thu, Sep 14, 2017 at 4:18 PM, Vladimir Barinov <vladimir.barinov@cogentembedded.com> wrote: > Add M3ULCB Kingfisher Device tree bindings Documentation, listing it as a > supported board. > > Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com> > --- > Changes in version 2: > - added own compatible value "shimafuji,kingfisher" Thanks for the update! > --- a/Documentation/devicetree/bindings/arm/shmobile.txt > +++ b/Documentation/devicetree/bindings/arm/shmobile.txt > @@ -85,6 +85,8 @@ Boards: > compatible = "renesas,lager", "renesas,r8a7790" > - M3ULCB (R-Car Starter Kit Pro, RTP0RC7796SKBX0010SA09 (M3 ES1.0)) > compatible = "renesas,m3ulcb", "renesas,r8a7796"; > + - M3ULCB Kingfisher (SBEV-RCAR-KF-M03) > + compatible = "shimafuji,kingfisher", "renesas,m3ulcb", "renesas,r8a7796"; > - Marzen (R0P7779A00010S) > compatible = "renesas,marzen", "renesas,r8a7779" > - Porter (M2-LCDP) As Kingfisher is an extension board, I meant to have a separate entry for it, not tied to M3ULCB or H3ULCB: - M3ULCB Kingfisher (SBEV-RCAR-KF-M03) compatible = "shimafuji,kingfisher" That way you don't need to list it twice (the board part number is the same for M3ULCB Kingfisher and H3ULCB Kingfisher anyway). Do you agree? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Geert, On 14.09.2017 17:55, Geert Uytterhoeven wrote: > Hi Vladimir, > > On Thu, Sep 14, 2017 at 4:18 PM, Vladimir Barinov > <vladimir.barinov@cogentembedded.com> wrote: >> Add M3ULCB Kingfisher Device tree bindings Documentation, listing it as a >> supported board. >> >> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com> >> --- >> Changes in version 2: >> - added own compatible value "shimafuji,kingfisher" > Thanks for the update! > >> --- a/Documentation/devicetree/bindings/arm/shmobile.txt >> +++ b/Documentation/devicetree/bindings/arm/shmobile.txt >> @@ -85,6 +85,8 @@ Boards: >> compatible = "renesas,lager", "renesas,r8a7790" >> - M3ULCB (R-Car Starter Kit Pro, RTP0RC7796SKBX0010SA09 (M3 ES1.0)) >> compatible = "renesas,m3ulcb", "renesas,r8a7796"; >> + - M3ULCB Kingfisher (SBEV-RCAR-KF-M03) >> + compatible = "shimafuji,kingfisher", "renesas,m3ulcb", "renesas,r8a7796"; >> - Marzen (R0P7779A00010S) >> compatible = "renesas,marzen", "renesas,r8a7779" >> - Porter (M2-LCDP) > As Kingfisher is an extension board, I meant to have a separate entry for it, > not tied to M3ULCB or H3ULCB: > > - M3ULCB Kingfisher (SBEV-RCAR-KF-M03) > compatible = "shimafuji,kingfisher" > > That way you don't need to list it twice (the board part number is the same > for M3ULCB Kingfisher and H3ULCB Kingfisher anyway). > Do you agree? Sorry for misunderstanding. Do you mean to add such entry: - Kingfisher (SBEV-RCAR-KF-M03) compatible = "shimafuji,kingfisher"
Hi Vladimir, On Thu, Sep 14, 2017 at 5:00 PM, Vladimir Barinov <vladimir.barinov@cogentembedded.com> wrote: > On 14.09.2017 17:55, Geert Uytterhoeven wrote: >> On Thu, Sep 14, 2017 at 4:18 PM, Vladimir Barinov >> <vladimir.barinov@cogentembedded.com> wrote: >>> Add M3ULCB Kingfisher Device tree bindings Documentation, listing it as a >>> supported board. >>> >>> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com> >>> --- >>> Changes in version 2: >>> - added own compatible value "shimafuji,kingfisher" >> >> Thanks for the update! >> >>> --- a/Documentation/devicetree/bindings/arm/shmobile.txt >>> +++ b/Documentation/devicetree/bindings/arm/shmobile.txt >>> @@ -85,6 +85,8 @@ Boards: >>> compatible = "renesas,lager", "renesas,r8a7790" >>> - M3ULCB (R-Car Starter Kit Pro, RTP0RC7796SKBX0010SA09 (M3 ES1.0)) >>> compatible = "renesas,m3ulcb", "renesas,r8a7796"; >>> + - M3ULCB Kingfisher (SBEV-RCAR-KF-M03) >>> + compatible = "shimafuji,kingfisher", "renesas,m3ulcb", >>> "renesas,r8a7796"; >>> - Marzen (R0P7779A00010S) >>> compatible = "renesas,marzen", "renesas,r8a7779" >>> - Porter (M2-LCDP) >> >> As Kingfisher is an extension board, I meant to have a separate entry for >> it, >> not tied to M3ULCB or H3ULCB: >> >> - M3ULCB Kingfisher (SBEV-RCAR-KF-M03) Sorry, bogus "M3ULCB" above. >> compatible = "shimafuji,kingfisher" >> >> That way you don't need to list it twice (the board part number is the >> same >> for M3ULCB Kingfisher and H3ULCB Kingfisher anyway). >> Do you agree? > > Sorry for misunderstanding. > > Do you mean to add such entry: > > - Kingfisher (SBEV-RCAR-KF-M03) > compatible = "shimafuji,kingfisher" Exactly. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Sep 14, 2017 at 05:18:40PM +0300, Vladimir Barinov wrote: > Add M3ULCB Kingfisher Device tree bindings Documentation, listing it as a > supported board. > > Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com> > --- > Changes in version 2: > - added own compatible value "shimafuji,kingfisher" > > Documentation/devicetree/bindings/arm/shmobile.txt | 1 + > 1 file changed, 1 insertion(+) I would refer if the patch subject was something like: ARM: shmobile: Document M3ULCB Kingfisher board DT bindings > > diff --git a/Documentation/devicetree/bindings/arm/shmobile.txt b/Documentation/devicetree/bindings/arm/shmobile.txt > index ae75cb3..89bd3a6 100644 > --- a/Documentation/devicetree/bindings/arm/shmobile.txt > +++ b/Documentation/devicetree/bindings/arm/shmobile.txt > @@ -85,6 +85,8 @@ Boards: > compatible = "renesas,lager", "renesas,r8a7790" > - M3ULCB (R-Car Starter Kit Pro, RTP0RC7796SKBX0010SA09 (M3 ES1.0)) > compatible = "renesas,m3ulcb", "renesas,r8a7796"; > + - M3ULCB Kingfisher (SBEV-RCAR-KF-M03) > + compatible = "shimafuji,kingfisher", "renesas,m3ulcb", "renesas,r8a7796"; > - Marzen (R0P7779A00010S) > compatible = "renesas,marzen", "renesas,r8a7779" > - Porter (M2-LCDP) > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/arm/shmobile.txt b/Documentation/devicetree/bindings/arm/shmobile.txt index ae75cb3..89bd3a6 100644 --- a/Documentation/devicetree/bindings/arm/shmobile.txt +++ b/Documentation/devicetree/bindings/arm/shmobile.txt @@ -85,6 +85,8 @@ Boards: compatible = "renesas,lager", "renesas,r8a7790" - M3ULCB (R-Car Starter Kit Pro, RTP0RC7796SKBX0010SA09 (M3 ES1.0)) compatible = "renesas,m3ulcb", "renesas,r8a7796"; + - M3ULCB Kingfisher (SBEV-RCAR-KF-M03) + compatible = "shimafuji,kingfisher", "renesas,m3ulcb", "renesas,r8a7796"; - Marzen (R0P7779A00010S) compatible = "renesas,marzen", "renesas,r8a7779" - Porter (M2-LCDP)
Add M3ULCB Kingfisher Device tree bindings Documentation, listing it as a supported board. Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com> --- Changes in version 2: - added own compatible value "shimafuji,kingfisher" Documentation/devicetree/bindings/arm/shmobile.txt | 1 + 1 file changed, 1 insertion(+)