configure: Allow --enable-seccomp on s390x, too

Message ID 1505385363-27717-1-git-send-email-thuth@redhat.com
State New
Headers show
Series
  • configure: Allow --enable-seccomp on s390x, too
Related show

Commit Message

Thomas Huth Sept. 14, 2017, 10:36 a.m.
libseccomp supports s390x since version 2.3.0, and I was able to start
a VM with "-sandbox on" without any obvious problems by using this patch,
so it should be safe to allow --enable-seccomp on s390x nowadays, too.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Eduardo Otubo Sept. 14, 2017, 11:24 a.m. | #1
On Thu, Sep 14, 2017 at 12:36:03PM +0200, Thomas Huth wrote:
> libseccomp supports s390x since version 2.3.0, and I was able to start
> a VM with "-sandbox on" without any obvious problems by using this patch,
> so it should be safe to allow --enable-seccomp on s390x nowadays, too.
> 

I don't have a s390x hardware to test so I'll have to trust you.
Anyone from IBM interested in testing this patch as well?

> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index fd7e3a5..83ba64e 100755
> --- a/configure
> +++ b/configure
> @@ -2032,7 +2032,7 @@ if test "$seccomp" != "no" ; then
>      arm|aarch64)
>          libseccomp_minver="2.2.3"
>          ;;
> -    ppc|ppc64)
> +    ppc|ppc64|s390x)
>          libseccomp_minver="2.3.0"
>          ;;
>      *)
> -- 
> 1.8.3.1
>
Christian Borntraeger Sept. 14, 2017, 11:55 a.m. | #2
On 09/14/2017 12:36 PM, Thomas Huth wrote:
> libseccomp supports s390x since version 2.3.0, and I was able to start
> a VM with "-sandbox on" without any obvious problems by using this patch,
> so it should be safe to allow --enable-seccomp on s390x nowadays, too.

Seems to work fine on s390x.
Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>

> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index fd7e3a5..83ba64e 100755
> --- a/configure
> +++ b/configure
> @@ -2032,7 +2032,7 @@ if test "$seccomp" != "no" ; then
>      arm|aarch64)
>          libseccomp_minver="2.2.3"
>          ;;
> -    ppc|ppc64)
> +    ppc|ppc64|s390x)
>          libseccomp_minver="2.3.0"
>          ;;
>      *)
>
Eduardo Otubo Sept. 14, 2017, 12:05 p.m. | #3
On Thu, Sep 14, 2017 at 01:55:46PM +0200, Christian Borntraeger wrote:
> On 09/14/2017 12:36 PM, Thomas Huth wrote:
> > libseccomp supports s390x since version 2.3.0, and I was able to start
> > a VM with "-sandbox on" without any obvious problems by using this patch,
> > so it should be safe to allow --enable-seccomp on s390x nowadays, too.
> 
> Seems to work fine on s390x.
> Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>

Cool, thanks :-)

Acked-by: Eduardo Otubo <otubo@redhat.com>

> 
> > 
> > Signed-off-by: Thomas Huth <thuth@redhat.com>
> > ---
> >  configure | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/configure b/configure
> > index fd7e3a5..83ba64e 100755
> > --- a/configure
> > +++ b/configure
> > @@ -2032,7 +2032,7 @@ if test "$seccomp" != "no" ; then
> >      arm|aarch64)
> >          libseccomp_minver="2.2.3"
> >          ;;
> > -    ppc|ppc64)
> > +    ppc|ppc64|s390x)
> >          libseccomp_minver="2.3.0"
> >          ;;
> >      *)
> > 
>
Halil Pasic Sept. 14, 2017, 1:29 p.m. | #4
On 09/14/2017 12:36 PM, Thomas Huth wrote:
> libseccomp supports s390x since version 2.3.0, and I was able to start
> a VM with "-sandbox on" without any obvious problems by using this patch,
> so it should be safe to allow --enable-seccomp on s390x nowadays, too.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>

ack
Cornelia Huck Sept. 14, 2017, 2:55 p.m. | #5
On Thu, 14 Sep 2017 12:36:03 +0200
Thomas Huth <thuth@redhat.com> wrote:

> libseccomp supports s390x since version 2.3.0, and I was able to start
> a VM with "-sandbox on" without any obvious problems by using this patch,
> so it should be safe to allow --enable-seccomp on s390x nowadays, too.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index fd7e3a5..83ba64e 100755
> --- a/configure
> +++ b/configure
> @@ -2032,7 +2032,7 @@ if test "$seccomp" != "no" ; then
>      arm|aarch64)
>          libseccomp_minver="2.2.3"
>          ;;
> -    ppc|ppc64)
> +    ppc|ppc64|s390x)
>          libseccomp_minver="2.3.0"
>          ;;
>      *)

Thanks, applied.

Patch

diff --git a/configure b/configure
index fd7e3a5..83ba64e 100755
--- a/configure
+++ b/configure
@@ -2032,7 +2032,7 @@  if test "$seccomp" != "no" ; then
     arm|aarch64)
         libseccomp_minver="2.2.3"
         ;;
-    ppc|ppc64)
+    ppc|ppc64|s390x)
         libseccomp_minver="2.3.0"
         ;;
     *)