[1/1] package/librsync: not available in static builds

Message ID 20170913101823.12808-1-bernd.kuhls@t-online.de
State Accepted
Headers show
Series
  • [1/1] package/librsync: not available in static builds
Related show

Commit Message

Bernd Kuhls Sept. 13, 2017, 10:18 a.m.
Upstream only support shared builds:
https://github.com/librsync/librsync/blob/master/CMakeLists.txt#L319

Fixes
http://autobuild.buildroot.net/results/4b8/4b8db2d520373d0c9127e0d7695b5aeda6925dc5/

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/librsync/Config.in | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Arnout Vandecappelle Sept. 24, 2017, 11:54 a.m. | #1
On 13-09-17 12:18, Bernd Kuhls wrote:
> Upstream only support shared builds:
> https://github.com/librsync/librsync/blob/master/CMakeLists.txt#L319
> 
> Fixes
> http://autobuild.buildroot.net/results/4b8/4b8db2d520373d0c9127e0d7695b5aeda6925dc5/
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>

 Applied to master, thanks.

 Regards,
 Arnout

> ---
>  package/librsync/Config.in | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/package/librsync/Config.in b/package/librsync/Config.in
> index 652f0cb276..6957ddcc0e 100644
> --- a/package/librsync/Config.in
> +++ b/package/librsync/Config.in
> @@ -1,5 +1,6 @@
>  config BR2_PACKAGE_LIBRSYNC
>  	bool "librsync"
> +	depends on !BR2_STATIC_LIBS
>  	select BR2_PACKAGE_ZLIB
>  	select BR2_PACKAGE_BZIP2
>  	select BR2_PACKAGE_POPT
> @@ -9,3 +10,6 @@ config BR2_PACKAGE_LIBRSYNC
>  	  rsync utility and is used in rproxy.
>  
>  	  https://github.com/librsync/librsync
> +
> +comment "librsync needs a toolchain w/ dynamic library support"
> +	depends on BR2_STATIC_LIBS
>
Peter Korsgaard Oct. 16, 2017, 10:02 p.m. | #2
>>>>> "Bernd" == Bernd Kuhls <bernd.kuhls@t-online.de> writes:

 > Upstream only support shared builds:
 > https://github.com/librsync/librsync/blob/master/CMakeLists.txt#L319

 > Fixes
 > http://autobuild.buildroot.net/results/4b8/4b8db2d520373d0c9127e0d7695b5aeda6925dc5/

 > Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>

Committed to 2017.08.x, thanks.

Patch

diff --git a/package/librsync/Config.in b/package/librsync/Config.in
index 652f0cb276..6957ddcc0e 100644
--- a/package/librsync/Config.in
+++ b/package/librsync/Config.in
@@ -1,5 +1,6 @@ 
 config BR2_PACKAGE_LIBRSYNC
 	bool "librsync"
+	depends on !BR2_STATIC_LIBS
 	select BR2_PACKAGE_ZLIB
 	select BR2_PACKAGE_BZIP2
 	select BR2_PACKAGE_POPT
@@ -9,3 +10,6 @@  config BR2_PACKAGE_LIBRSYNC
 	  rsync utility and is used in rproxy.
 
 	  https://github.com/librsync/librsync
+
+comment "librsync needs a toolchain w/ dynamic library support"
+	depends on BR2_STATIC_LIBS