[U-Boot,2/2] ls1088aqds: Enable USB command on QDS for qspi-boot

Message ID 1505288964-15071-2-git-send-email-Ashish.Kumar@nxp.com
State Superseded
Delegated to: York Sun
Headers show
Series
  • [U-Boot,1/2] ls1088ardb: Enable USB command RDB qspi-boot
Related show

Commit Message

Ashish Kumar Sept. 13, 2017, 7:49 a.m.
Signed-off-by: Amrita Kumari <amrita.kumari@nxp.com>
Signed-off-by: Ashish Kumar <Ashish.Kumar@nxp.com>
---
v1:
Rebased to
ba39608 ARM: DRA72x: Add support for detection of DRA71x SR 2.1

 configs/ls1088aqds_qspi_defconfig | 8 ++++++++
 include/configs/ls1088aqds.h      | 5 +++++
 2 files changed, 13 insertions(+)

Comments

Bin Meng Sept. 13, 2017, 8:44 a.m. | #1
On Wed, Sep 13, 2017 at 3:49 PM, Ashish Kumar <Ashish.Kumar@nxp.com> wrote:
> Signed-off-by: Amrita Kumari <amrita.kumari@nxp.com>
> Signed-off-by: Ashish Kumar <Ashish.Kumar@nxp.com>
> ---
> v1:
> Rebased to
> ba39608 ARM: DRA72x: Add support for detection of DRA71x SR 2.1
>
>  configs/ls1088aqds_qspi_defconfig | 8 ++++++++
>  include/configs/ls1088aqds.h      | 5 +++++
>  2 files changed, 13 insertions(+)
>
> diff --git a/configs/ls1088aqds_qspi_defconfig b/configs/ls1088aqds_qspi_defconfig
> index 4b0d604..a24a601 100644
> --- a/configs/ls1088aqds_qspi_defconfig
> +++ b/configs/ls1088aqds_qspi_defconfig
> @@ -31,3 +31,11 @@ CONFIG_FSL_DSPI=y
>  CONFIG_EFI_LOADER_BOUNCE_BUFFER=y
>  # CONFIG_DISPLAY_BOARDINFO is not set
>  CONFIG_FSL_LS_PPA=y
> +CONFIG_USB=y
> +CONFIG_USB_GADGET=y
> +CONFIG_CMD_USB=y
> +CONFIG_DM_USB=y
> +CONFIG_USB_XHCI_HCD=y
> +CONFIG_USB_XHCI_DWC3=y
> +CONFIG_USB_DWC3=y
> +CONFIG_USB_STORAGE=y
> diff --git a/include/configs/ls1088aqds.h b/include/configs/ls1088aqds.h
> index 3547b0b..c57e1f5 100644
> --- a/include/configs/ls1088aqds.h
> +++ b/include/configs/ls1088aqds.h
> @@ -363,6 +363,11 @@ unsigned long get_board_ddr_clk(void);
>         "mcmemsize=0x70000000 \0"
>  #endif
>
> +/*  USB  */
> +#define CONFIG_HAS_FSL_XHCI_USB
> +#define CONFIG_USB_XHCI_FSL

Please convert this as a Kconfig option.

> +#define CONFIG_USB_MAX_CONTROLLER_COUNT                2

CONFIG_USB_MAX_CONTROLLER_COUNT is not used anywhere in DM USB. Please remove.

> +
>  #ifdef CONFIG_FSL_MC_ENET
>  #define CONFIG_FSL_MEMAC
>  #define        CONFIG_PHYLIB
> --

Regards,
Bin
Ashish Kumar Sept. 13, 2017, 4:49 p.m. | #2
Hello Ran,

Could you please help here to convert to Kconfig option?

Regards
Ashish

-----Original Message-----
From: Bin Meng [mailto:bmeng.cn@gmail.com] 

Sent: Wednesday, September 13, 2017 2:15 PM
To: Ashish Kumar <ashish.kumar@nxp.com>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>; Amrita Kumari <amrita.kumari@nxp.com>; prabhakar.khuswaha@nxp.com
Subject: Re: [U-Boot] [PATCH 2/2] ls1088aqds: Enable USB command on QDS for qspi-boot

On Wed, Sep 13, 2017 at 3:49 PM, Ashish Kumar <Ashish.Kumar@nxp.com> wrote:
> Signed-off-by: Amrita Kumari <amrita.kumari@nxp.com>

> Signed-off-by: Ashish Kumar <Ashish.Kumar@nxp.com>

> ---

> v1:

> Rebased to

> ba39608 ARM: DRA72x: Add support for detection of DRA71x SR 2.1

>

>  configs/ls1088aqds_qspi_defconfig | 8 ++++++++

>  include/configs/ls1088aqds.h      | 5 +++++

>  2 files changed, 13 insertions(+)

>

> diff --git a/configs/ls1088aqds_qspi_defconfig 

> b/configs/ls1088aqds_qspi_defconfig

> index 4b0d604..a24a601 100644

> --- a/configs/ls1088aqds_qspi_defconfig

> +++ b/configs/ls1088aqds_qspi_defconfig

> @@ -31,3 +31,11 @@ CONFIG_FSL_DSPI=y

>  CONFIG_EFI_LOADER_BOUNCE_BUFFER=y

>  # CONFIG_DISPLAY_BOARDINFO is not set  CONFIG_FSL_LS_PPA=y

> +CONFIG_USB=y

> +CONFIG_USB_GADGET=y

> +CONFIG_CMD_USB=y

> +CONFIG_DM_USB=y

> +CONFIG_USB_XHCI_HCD=y

> +CONFIG_USB_XHCI_DWC3=y

> +CONFIG_USB_DWC3=y

> +CONFIG_USB_STORAGE=y

> diff --git a/include/configs/ls1088aqds.h 

> b/include/configs/ls1088aqds.h index 3547b0b..c57e1f5 100644

> --- a/include/configs/ls1088aqds.h

> +++ b/include/configs/ls1088aqds.h

> @@ -363,6 +363,11 @@ unsigned long get_board_ddr_clk(void);

>         "mcmemsize=0x70000000 \0"

>  #endif

>

> +/*  USB  */

> +#define CONFIG_HAS_FSL_XHCI_USB

> +#define CONFIG_USB_XHCI_FSL


Please convert this as a Kconfig option.

> +#define CONFIG_USB_MAX_CONTROLLER_COUNT                2


CONFIG_USB_MAX_CONTROLLER_COUNT is not used anywhere in DM USB. Please remove.

> +

>  #ifdef CONFIG_FSL_MC_ENET

>  #define CONFIG_FSL_MEMAC

>  #define        CONFIG_PHYLIB

> --


Regards,
Bin
Ran Wang Sept. 14, 2017, 2:03 a.m. | #3
Hi Ashish

> -----Original Message-----

> From: Ashish Kumar

> Sent: Thursday, September 14, 2017 12:49 AM

> To: Ran Wang <ran.wang_1@nxp.com>

> Cc: U-Boot Mailing List <u-boot@lists.denx.de>; Bin Meng

> <bmeng.cn@gmail.com>; prabhakar.khuswaha@nxp.com

> Subject: RE: [U-Boot] [PATCH 2/2] ls1088aqds: Enable USB command on QDS for

> qspi-boot

> 

> Hello Ran,

> 

> Could you please help here to convert to Kconfig option?

> 

> Regards

> Ashish

> 

> -----Original Message-----

> From: Bin Meng [mailto:bmeng.cn@gmail.com]

> Sent: Wednesday, September 13, 2017 2:15 PM

> To: Ashish Kumar <ashish.kumar@nxp.com>

> Cc: U-Boot Mailing List <u-boot@lists.denx.de>; Amrita Kumari

> <amrita.kumari@nxp.com>; prabhakar.khuswaha@nxp.com

> Subject: Re: [U-Boot] [PATCH 2/2] ls1088aqds: Enable USB command on QDS for

> qspi-boot

> 

> On Wed, Sep 13, 2017 at 3:49 PM, Ashish Kumar <Ashish.Kumar@nxp.com>

> wrote:

> > Signed-off-by: Amrita Kumari <amrita.kumari@nxp.com>

> > Signed-off-by: Ashish Kumar <Ashish.Kumar@nxp.com>

> > ---

> > v1:

> > Rebased to

> > ba39608 ARM: DRA72x: Add support for detection of DRA71x SR 2.1

> >

> >  configs/ls1088aqds_qspi_defconfig | 8 ++++++++

> >  include/configs/ls1088aqds.h      | 5 +++++

> >  2 files changed, 13 insertions(+)

> >

> > diff --git a/configs/ls1088aqds_qspi_defconfig

> > b/configs/ls1088aqds_qspi_defconfig

> > index 4b0d604..a24a601 100644

> > --- a/configs/ls1088aqds_qspi_defconfig

> > +++ b/configs/ls1088aqds_qspi_defconfig

> > @@ -31,3 +31,11 @@ CONFIG_FSL_DSPI=y

> >  CONFIG_EFI_LOADER_BOUNCE_BUFFER=y

> >  # CONFIG_DISPLAY_BOARDINFO is not set  CONFIG_FSL_LS_PPA=y

> > +CONFIG_USB=y

> > +CONFIG_USB_GADGET=y

> > +CONFIG_CMD_USB=y

> > +CONFIG_DM_USB=y

> > +CONFIG_USB_XHCI_HCD=y

> > +CONFIG_USB_XHCI_DWC3=y

> > +CONFIG_USB_DWC3=y

> > +CONFIG_USB_STORAGE=y

> > diff --git a/include/configs/ls1088aqds.h

> > b/include/configs/ls1088aqds.h index 3547b0b..c57e1f5 100644

> > --- a/include/configs/ls1088aqds.h

> > +++ b/include/configs/ls1088aqds.h

> > @@ -363,6 +363,11 @@ unsigned long get_board_ddr_clk(void);

> >         "mcmemsize=0x70000000 \0"

> >  #endif

> >

> > +/*  USB  */

> > +#define CONFIG_HAS_FSL_XHCI_USB

> > +#define CONFIG_USB_XHCI_FSL

> 

> Please convert this as a Kconfig option.

> 

> > +#define CONFIG_USB_MAX_CONTROLLER_COUNT                2

> 

> CONFIG_USB_MAX_CONTROLLER_COUNT is not used anywhere in DM USB.

> Please remove.


Sure, so I need to continue your patchwork or submit it as a new one after yours applied?
BR
Ran
> 

> > +

> >  #ifdef CONFIG_FSL_MC_ENET

> >  #define CONFIG_FSL_MEMAC

> >  #define        CONFIG_PHYLIB

> > --

> 

> Regards,

> Bin

Patch

diff --git a/configs/ls1088aqds_qspi_defconfig b/configs/ls1088aqds_qspi_defconfig
index 4b0d604..a24a601 100644
--- a/configs/ls1088aqds_qspi_defconfig
+++ b/configs/ls1088aqds_qspi_defconfig
@@ -31,3 +31,11 @@  CONFIG_FSL_DSPI=y
 CONFIG_EFI_LOADER_BOUNCE_BUFFER=y
 # CONFIG_DISPLAY_BOARDINFO is not set
 CONFIG_FSL_LS_PPA=y
+CONFIG_USB=y
+CONFIG_USB_GADGET=y
+CONFIG_CMD_USB=y
+CONFIG_DM_USB=y
+CONFIG_USB_XHCI_HCD=y
+CONFIG_USB_XHCI_DWC3=y
+CONFIG_USB_DWC3=y
+CONFIG_USB_STORAGE=y
diff --git a/include/configs/ls1088aqds.h b/include/configs/ls1088aqds.h
index 3547b0b..c57e1f5 100644
--- a/include/configs/ls1088aqds.h
+++ b/include/configs/ls1088aqds.h
@@ -363,6 +363,11 @@  unsigned long get_board_ddr_clk(void);
 	"mcmemsize=0x70000000 \0"
 #endif
 
+/*  USB  */
+#define CONFIG_HAS_FSL_XHCI_USB
+#define CONFIG_USB_XHCI_FSL
+#define CONFIG_USB_MAX_CONTROLLER_COUNT                2
+
 #ifdef CONFIG_FSL_MC_ENET
 #define CONFIG_FSL_MEMAC
 #define	CONFIG_PHYLIB