Patchwork [karmic,CVE,1/1] net: packet: fix information leak to userland

login
register
mail settings
Submitter Andy Whitcroft
Date Feb. 1, 2011, 2:26 p.m.
Message ID <1296570387-30250-4-git-send-email-apw@canonical.com>
Download mbox | patch
Permalink /patch/81314/
State Accepted
Commit c8b5a23c8ce3f94fabaab7081240d0a1fc9671aa
Headers show

Comments

Andy Whitcroft - Feb. 1, 2011, 2:26 p.m.
packet_getname_spkt() doesn't initialize all members of sa_data field of
sockaddr struct if strlen(dev->name) < 13.  This structure is then copied
to userland.  It leads to leaking of contents of kernel stack memory.
We have to fully fill sa_data with strncpy() instead of strlcpy().

The same with packet_getname(): it doesn't initialize sll_pkttype field of
sockaddr_ll.  Set it to zero.

Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

CVE-2010-3876
BugLink: http://bugs.launchpad.net/bugs/710714
(backported from commit 67286640f638f5ad41a946b9a3dc75327950248f upstream)
Signed-off-by: Andy Whitcroft <apw@canonical.com>
---
 net/packet/af_packet.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

Patch

diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
index f9f7177..f47d0b3 100644
--- a/net/packet/af_packet.c
+++ b/net/packet/af_packet.c
@@ -1524,7 +1524,7 @@  static int packet_getname_spkt(struct socket *sock, struct sockaddr *uaddr,
 	uaddr->sa_family = AF_PACKET;
 	dev = dev_get_by_index(sock_net(sk), pkt_sk(sk)->ifindex);
 	if (dev) {
-		strlcpy(uaddr->sa_data, dev->name, 15);
+		strncpy(uaddr->sa_data, dev->name, 14);
 		dev_put(dev);
 	} else
 		memset(uaddr->sa_data, 0, 14);
@@ -1547,6 +1547,7 @@  static int packet_getname(struct socket *sock, struct sockaddr *uaddr,
 	sll->sll_family = AF_PACKET;
 	sll->sll_ifindex = po->ifindex;
 	sll->sll_protocol = po->num;
+	sll->sll_pkttype = 0;
 	dev = dev_get_by_index(sock_net(sk), po->ifindex);
 	if (dev) {
 		sll->sll_hatype = dev->type;