[SRU,Zesty,4/5] tcp_bbr: remove sk_pacing_rate=0 transient during init

Message ID 1505257937-17925-4-git-send-email-vlee@freedesktop.org
State New
Headers show
Series
  • Untitled series #2787
Related show

Commit Message

Vinson Lee Sept. 12, 2017, 11:12 p.m.
From: Neal Cardwell <ncardwell@google.com>

BugLink: https://bugs.launchpad.net/bugs/1708604

Fix a corner case noticed by Eric Dumazet, where BBR's setting
sk->sk_pacing_rate to 0 during initialization could theoretically
cause packets in the sending host to hang if there were packets "in
flight" in the pacing infrastructure at the time the BBR congestion
control state is initialized. This could occur if the pacing
infrastructure happened to race with bbr_init() in a way such that the
pacer read the 0 rather than the immediately following non-zero pacing
rate.

Fixes: 0f8782ea1497 ("tcp_bbr: add BBR congestion control")
Reported-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Neal Cardwell <ncardwell@google.com>
Signed-off-by: Yuchung Cheng <ycheng@google.com>
Signed-off-by: Soheil Hassas Yeganeh <soheil@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
(cherry picked from commit 1d3648eb5d1fe9ed3d095ed8fa19ad11ca4c8bc0)
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
---
 net/ipv4/tcp_bbr.c | 1 -
 1 file changed, 1 deletion(-)

Patch

diff --git a/net/ipv4/tcp_bbr.c b/net/ipv4/tcp_bbr.c
index e69c8b44568a..20d834fd557d 100644
--- a/net/ipv4/tcp_bbr.c
+++ b/net/ipv4/tcp_bbr.c
@@ -838,7 +838,6 @@  static void bbr_init(struct sock *sk)
 
 	minmax_reset(&bbr->bw, bbr->rtt_cnt, 0);  /* init max bw to 0 */
 
-	sk->sk_pacing_rate = 0;		/* force an update of sk_pacing_rate */
 	bbr_init_pacing_rate_from_rtt(sk);
 
 	bbr->restore_cwnd = 0;