| Message ID | 1296568063-12010-2-git-send-email-aghayal@codeaurora.org |
|---|---|
| State | Not Applicable |
| Headers | show |
On Tue, Feb 1, 2011 at 9:47 PM, Anirudh Ghayal <aghayal@codeaurora.org> wrote: > From: Trilok Soni <tsoni@codeaurora.org> > > Some keyboard controller have support for more than > 16 columns and rows. Moving this value to 32. > > Cc: Eric Miao <eric.y.miao@gmail.com> > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> > Signed-off-by: Trilok Soni <tsoni@codeaurora.org> This looks good to me, as long as the bits don't exceed 256, which is used in the #KEY() macro. So far, 32 looks to be a sane number to me, unless we have further requirement to get this larger. Acked-by: Eric Miao <eric.y.miao@gmail.com> > --- > Changes from v1: > Moved the max columns and rows to 32 > > include/linux/input/matrix_keypad.h | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/input/matrix_keypad.h b/include/linux/input/matrix_keypad.h > index 6974746..fe7c4b9 100644 > --- a/include/linux/input/matrix_keypad.h > +++ b/include/linux/input/matrix_keypad.h > @@ -4,8 +4,8 @@ > #include <linux/types.h> > #include <linux/input.h> > > -#define MATRIX_MAX_ROWS 16 > -#define MATRIX_MAX_COLS 16 > +#define MATRIX_MAX_ROWS 32 > +#define MATRIX_MAX_COLS 32 > > #define KEY(row, col, val) ((((row) & (MATRIX_MAX_ROWS - 1)) << 24) |\ > (((col) & (MATRIX_MAX_COLS - 1)) << 16) |\ > -- > 1.7.3.5 > >
Hi Dmitry, On 2/9/2011 1:32 PM, Eric Miao wrote: > On Tue, Feb 1, 2011 at 9:47 PM, Anirudh Ghayal <aghayal@codeaurora.org> wrote: >> From: Trilok Soni <tsoni@codeaurora.org> >> >> Some keyboard controller have support for more than >> 16 columns and rows. Moving this value to 32. >> >> Cc: Eric Miao <eric.y.miao@gmail.com> >> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> >> Signed-off-by: Trilok Soni <tsoni@codeaurora.org> > > This looks good to me, as long as the bits don't exceed 256, which > is used in the #KEY() macro. So far, 32 looks to be a sane number > to me, unless we have further requirement to get this larger. > > Acked-by: Eric Miao <eric.y.miao@gmail.com> > Are you going to pick up this patch only from the series you want us to get it submitted it separately? ---Trilok Soni
On Thu, Feb 10, 2011 at 8:20 PM, Trilok Soni <tsoni@codeaurora.org> wrote: > Hi Dmitry, > > On 2/9/2011 1:32 PM, Eric Miao wrote: >> On Tue, Feb 1, 2011 at 9:47 PM, Anirudh Ghayal <aghayal@codeaurora.org> wrote: >>> From: Trilok Soni <tsoni@codeaurora.org> >>> >>> Some keyboard controller have support for more than >>> 16 columns and rows. Moving this value to 32. >>> >>> Cc: Eric Miao <eric.y.miao@gmail.com> >>> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> >>> Signed-off-by: Trilok Soni <tsoni@codeaurora.org> >> >> This looks good to me, as long as the bits don't exceed 256, which >> is used in the #KEY() macro. So far, 32 looks to be a sane number >> to me, unless we have further requirement to get this larger. >> >> Acked-by: Eric Miao <eric.y.miao@gmail.com> >> > > Are you going to pick up this patch only from the series you want us to get > it submitted it separately? I believe Dmitry will pick this series once all the patches are reviewed?
diff --git a/include/linux/input/matrix_keypad.h b/include/linux/input/matrix_keypad.h index 6974746..fe7c4b9 100644 --- a/include/linux/input/matrix_keypad.h +++ b/include/linux/input/matrix_keypad.h @@ -4,8 +4,8 @@ #include <linux/types.h> #include <linux/input.h> -#define MATRIX_MAX_ROWS 16 -#define MATRIX_MAX_COLS 16 +#define MATRIX_MAX_ROWS 32 +#define MATRIX_MAX_COLS 32 #define KEY(row, col, val) ((((row) & (MATRIX_MAX_ROWS - 1)) << 24) |\ (((col) & (MATRIX_MAX_COLS - 1)) << 16) |\