[ovs-dev,merge,native,tunneling,and,port,2/7] ofproto-dpif-xlate: Remove uncessary assignment

Message ID 1505245749-3402-2-git-send-email-azhou@ovn.org
State New
Headers show
Series
  • [ovs-dev,merge,native,tunneling,and,port,1/7] ofproto-dpif: Unfreeze within clone
Related show

Commit Message

Andy Zhou Sept. 12, 2017, 7:49 p.m.
Signed-off-by: Andy Zhou <azhou@ovn.org>
---
 ofproto/ofproto-dpif-xlate.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Greg Rose Sept. 21, 2017, 4:45 p.m. | #1
On 09/12/2017 12:49 PM, Andy Zhou wrote:
> Signed-off-by: Andy Zhou <azhou@ovn.org>
> ---
>   ofproto/ofproto-dpif-xlate.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c
> index e5ad832d7c47..d5b47666e974 100644
> --- a/ofproto/ofproto-dpif-xlate.c
> +++ b/ofproto/ofproto-dpif-xlate.c
> @@ -5373,7 +5373,6 @@ compose_clone(struct xlate_ctx *ctx, const struct ofpact_nest *oc)
>       if (ctx->xbridge->support.clone) { /* Use clone action */
>           /* Use clone action as datapath clone. */
>           offset = nl_msg_start_nested(ctx->odp_actions, OVS_ACTION_ATTR_CLONE);
> -        ac_offset = ctx->odp_actions->size;
>           do_xlate_actions(oc->actions, oc_actions_len, ctx);
>           if (ctx->freezing) {
>               finish_freezing(ctx);
> 

Tested-by: Greg Rose <gvrose8192@gmail.com>
Reviewed-by: Greg Rose <gvrose8192@gmail.com>

Patch

diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c
index e5ad832d7c47..d5b47666e974 100644
--- a/ofproto/ofproto-dpif-xlate.c
+++ b/ofproto/ofproto-dpif-xlate.c
@@ -5373,7 +5373,6 @@  compose_clone(struct xlate_ctx *ctx, const struct ofpact_nest *oc)
     if (ctx->xbridge->support.clone) { /* Use clone action */
         /* Use clone action as datapath clone. */
         offset = nl_msg_start_nested(ctx->odp_actions, OVS_ACTION_ATTR_CLONE);
-        ac_offset = ctx->odp_actions->size;
         do_xlate_actions(oc->actions, oc_actions_len, ctx);
         if (ctx->freezing) {
             finish_freezing(ctx);