Fix GIMPLE FE test (PR testsuite/82114)

Message ID 93de6075-90de-7027-bb9e-bafca9f7b89f@suse.cz
State New
Headers show
Series
  • Fix GIMPLE FE test (PR testsuite/82114)
Related show

Commit Message

Martin Liška Sept. 12, 2017, 7:44 a.m.
Hello.

Simple fix for args == 0 also returns 0 return value.

Patch can bootstrap on ppc64le-redhat-linux and survives regression tests.

Ready to be installed?
Martin

gcc/testsuite/ChangeLog:

2017-09-11  Martin Liska  <mliska@suse.cz>

	PR testsuite/82114
	* gcc.dg/gimplefe-14.c (main): Add handling of case 0.
---
 gcc/testsuite/gcc.dg/gimplefe-14.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Aldy Hernandez Sept. 12, 2017, 12:29 p.m. | #1
I'm going to abuse either my *gimpl* maintainer hat or my obvious hat
and approve this.

However, since we already have another test that looks the same
(gimplefe-error-2.c) but without the 0 case, it would probably be best
to add a comment in gimplefe-14.c as to why there is a 0 case.  In the
case of gimplefe-error-2.c, it doesn't matter because it is only a
compile test.

OK with that nit.


On Tue, Sep 12, 2017 at 3:44 AM, Martin Liška <mliska@suse.cz> wrote:
> Hello.
>
> Simple fix for args == 0 also returns 0 return value.
>
> Patch can bootstrap on ppc64le-redhat-linux and survives regression tests.
>
> Ready to be installed?
> Martin
>
> gcc/testsuite/ChangeLog:
>
> 2017-09-11  Martin Liska  <mliska@suse.cz>
>
>         PR testsuite/82114
>         * gcc.dg/gimplefe-14.c (main): Add handling of case 0.
> ---
>  gcc/testsuite/gcc.dg/gimplefe-14.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
>
Martin Liška Sept. 12, 2017, 2:33 p.m. | #2
On 09/12/2017 02:29 PM, Aldy Hernandez wrote:
> I'm going to abuse either my *gimpl* maintainer hat or my obvious hat
> and approve this.
> 
> However, since we already have another test that looks the same
> (gimplefe-error-2.c) but without the 0 case, it would probably be best
> to add a comment in gimplefe-14.c as to why there is a 0 case.  In the
> case of gimplefe-error-2.c, it doesn't matter because it is only a
> compile test.
> 
> OK with that nit.

Thanks for the note, installed as r252024.

Martin

> 
> 
> On Tue, Sep 12, 2017 at 3:44 AM, Martin Liška <mliska@suse.cz> wrote:
>> Hello.
>>
>> Simple fix for args == 0 also returns 0 return value.
>>
>> Patch can bootstrap on ppc64le-redhat-linux and survives regression tests.
>>
>> Ready to be installed?
>> Martin
>>
>> gcc/testsuite/ChangeLog:
>>
>> 2017-09-11  Martin Liska  <mliska@suse.cz>
>>
>>         PR testsuite/82114
>>         * gcc.dg/gimplefe-14.c (main): Add handling of case 0.
>> ---
>>  gcc/testsuite/gcc.dg/gimplefe-14.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>

Patch

diff --git a/gcc/testsuite/gcc.dg/gimplefe-14.c b/gcc/testsuite/gcc.dg/gimplefe-14.c
index c0dd54ab430..81f2c03264b 100644
--- a/gcc/testsuite/gcc.dg/gimplefe-14.c
+++ b/gcc/testsuite/gcc.dg/gimplefe-14.c
@@ -7,7 +7,7 @@  main (int argc, char * * argv)
   int a;
 
   bb_2:
-  switch (argc_2(D)) {default: L2; case 1: L0; case 2: L1; }
+  switch (argc_2(D)) {default: L2; case 0: L0; case 1: L0; case 2: L1; }
 
 L0:
   a_4 = 0;