Patchwork Fix PR47561: print the Graphite flags.

login
register
mail settings
Submitter Sebastian Pop
Date Feb. 1, 2011, 4:50 a.m.
Message ID <1296535839-8761-1-git-send-email-sebpop@gmail.com>
Download mbox | patch
Permalink /patch/81266/
State New
Headers show

Comments

Sebastian Pop - Feb. 1, 2011, 4:50 a.m.
Hi,

when GCC is not configured with Graphite, it prints an error message
whenever a flag depending on Graphite is used.

This patch improves the printed message by listing all the flags that
cannot be used.  The patch also adds a missing flag -floop-flatten to
the list.

Regstrap in progress on amd64-linux.  Ok for trunk?

Thanks,
Sebastian

2011-01-31  Sebastian Pop  <sebastian.pop@amd.com>

	PR tree-optimization/47561
	* toplev.c (process_options): Print the Graphite flags.  Add
	flag_loop_flatten to the list of options requiring Graphite.
---
 gcc/ChangeLog |    6 ++++++
 gcc/toplev.c  |    8 ++++++--
 2 files changed, 12 insertions(+), 2 deletions(-)
Richard Guenther - Feb. 1, 2011, 9:39 a.m.
On Mon, 31 Jan 2011, Sebastian Pop wrote:

> Hi,
> 
> when GCC is not configured with Graphite, it prints an error message
> whenever a flag depending on Graphite is used.
> 
> This patch improves the printed message by listing all the flags that
> cannot be used.  The patch also adds a missing flag -floop-flatten to
> the list.
> 
> Regstrap in progress on amd64-linux.  Ok for trunk?

Ok.

Thanks,
Richard.

> Thanks,
> Sebastian
> 
> 2011-01-31  Sebastian Pop  <sebastian.pop@amd.com>
> 
> 	PR tree-optimization/47561
> 	* toplev.c (process_options): Print the Graphite flags.  Add
> 	flag_loop_flatten to the list of options requiring Graphite.
> ---
>  gcc/ChangeLog |    6 ++++++
>  gcc/toplev.c  |    8 ++++++--
>  2 files changed, 12 insertions(+), 2 deletions(-)
> 
> diff --git a/gcc/ChangeLog b/gcc/ChangeLog
> index a17a9a3..d674043 100644
> --- a/gcc/ChangeLog
> +++ b/gcc/ChangeLog
> @@ -1,5 +1,11 @@
>  2011-01-31  Sebastian Pop  <sebastian.pop@amd.com>
>  
> +	PR tree-optimization/47561
> +	* toplev.c (process_options): Print the Graphite flags.  Add
> +	flag_loop_flatten to the list of options requiring Graphite.
> +
> +2011-01-31  Sebastian Pop  <sebastian.pop@amd.com>
> +
>  	* common.opt (ftree-loop-linear): Use Alias to make it an alias of
>  	-floop-interchange.
>  	* invoke.texi (-ftree-loop-linear): Make it clear that this flag
> diff --git a/gcc/toplev.c b/gcc/toplev.c
> index 78985cb..082c842 100644
> --- a/gcc/toplev.c
> +++ b/gcc/toplev.c
> @@ -1314,12 +1314,16 @@ process_options (void)
>  
>  #ifndef HAVE_cloog
>    if (flag_graphite
> +      || flag_graphite_identity
>        || flag_loop_block
> +      || flag_loop_flatten
>        || flag_loop_interchange
>        || flag_loop_strip_mine
> -      || flag_graphite_identity
>        || flag_loop_parallelize_all)
> -    sorry ("Graphite loop optimizations cannot be used");
> +    sorry ("Graphite loop optimizations cannot be used (-fgraphite, "
> +	   "-fgraphite-identity, -floop-block, -floop-flatten, "
> +	   "-floop-interchange, -floop-strip-mine, -floop-parallelize-all, "
> +	   "and -ftree-loop-linear)");
>  #endif
>  
>    /* Unrolling all loops implies that standard loop unrolling must also
>

Patch

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index a17a9a3..d674043 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,5 +1,11 @@ 
 2011-01-31  Sebastian Pop  <sebastian.pop@amd.com>
 
+	PR tree-optimization/47561
+	* toplev.c (process_options): Print the Graphite flags.  Add
+	flag_loop_flatten to the list of options requiring Graphite.
+
+2011-01-31  Sebastian Pop  <sebastian.pop@amd.com>
+
 	* common.opt (ftree-loop-linear): Use Alias to make it an alias of
 	-floop-interchange.
 	* invoke.texi (-ftree-loop-linear): Make it clear that this flag
diff --git a/gcc/toplev.c b/gcc/toplev.c
index 78985cb..082c842 100644
--- a/gcc/toplev.c
+++ b/gcc/toplev.c
@@ -1314,12 +1314,16 @@  process_options (void)
 
 #ifndef HAVE_cloog
   if (flag_graphite
+      || flag_graphite_identity
       || flag_loop_block
+      || flag_loop_flatten
       || flag_loop_interchange
       || flag_loop_strip_mine
-      || flag_graphite_identity
       || flag_loop_parallelize_all)
-    sorry ("Graphite loop optimizations cannot be used");
+    sorry ("Graphite loop optimizations cannot be used (-fgraphite, "
+	   "-fgraphite-identity, -floop-block, -floop-flatten, "
+	   "-floop-interchange, -floop-strip-mine, -floop-parallelize-all, "
+	   "and -ftree-loop-linear)");
 #endif
 
   /* Unrolling all loops implies that standard loop unrolling must also