[2/2] dmi: dmicheck: Add BMC Interface Type definitions from IPMI spec

Message ID 1505165777-17121-2-git-send-email-jhugo@codeaurora.org
State Superseded
Headers show
Series
  • Untitled series #2587
Related show

Commit Message

Jeffrey Hugo Sept. 11, 2017, 9:36 p.m.
The Intelligent Platform Management Interface (IPMI) Specification defines
BMC Interface Types in section C1-1.1.  Type 4 is an addition in the IPMI
spec which does not appear in the SMBIOS spec, which means "SSIF: SMBus
System Interface".

Add type 4 as a valid type to the test.

Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org>
---
 src/dmi/dmicheck/dmicheck.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alex Hung Sept. 12, 2017, 5:04 a.m. | #1
On 2017-09-11 02:36 PM, Jeffrey Hugo wrote:
> The Intelligent Platform Management Interface (IPMI) Specification defines
> BMC Interface Types in section C1-1.1.  Type 4 is an addition in the IPMI
> spec which does not appear in the SMBIOS spec, which means "SSIF: SMBus
> System Interface".
> 
> Add type 4 as a valid type to the test.
> 
> Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org>
> ---
>   src/dmi/dmicheck/dmicheck.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
> index c0e78f0..0db787f 100644
> --- a/src/dmi/dmicheck/dmicheck.c
> +++ b/src/dmi/dmicheck/dmicheck.c
> @@ -1772,7 +1772,7 @@ static void dmicheck_entry(fwts_framework *fw,
>   
>   			dmi_reserved_bits_check(fw, table, addr, "Base Addr Modifier/Interrupt Info", hdr, sizeof(uint8_t), 0x10, 2, 2);
>   			dmi_reserved_bits_check(fw, table, addr, "Base Addr Modifier/Interrupt Info", hdr, sizeof(uint8_t), 0x10, 5, 5);
> -			dmi_min_max_mask_uint8_check(fw, table, addr, "Base Addr Modifier/Interrupt Info)", hdr, 0x10, 0x0, 0x3, 6, 0x3);
> +			dmi_min_max_mask_uint8_check(fw, table, addr, "Base Addr Modifier/Interrupt Info)", hdr, 0x10, 0x0, 0x4, 6, 0x3);
>   			break;
>   
>   		case 39: /* 7.40 */
> 

Acked-by: Alex Hung <alex.hung@canonical.com>
Colin King Sept. 12, 2017, 8 a.m. | #2
On 11/09/17 22:36, Jeffrey Hugo wrote:
> The Intelligent Platform Management Interface (IPMI) Specification defines
> BMC Interface Types in section C1-1.1.  Type 4 is an addition in the IPMI
> spec which does not appear in the SMBIOS spec, which means "SSIF: SMBus
> System Interface".
> 
> Add type 4 as a valid type to the test.
> 
> Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org>
> ---
>  src/dmi/dmicheck/dmicheck.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
> index c0e78f0..0db787f 100644
> --- a/src/dmi/dmicheck/dmicheck.c
> +++ b/src/dmi/dmicheck/dmicheck.c
> @@ -1772,7 +1772,7 @@ static void dmicheck_entry(fwts_framework *fw,
>  
>  			dmi_reserved_bits_check(fw, table, addr, "Base Addr Modifier/Interrupt Info", hdr, sizeof(uint8_t), 0x10, 2, 2);
>  			dmi_reserved_bits_check(fw, table, addr, "Base Addr Modifier/Interrupt Info", hdr, sizeof(uint8_t), 0x10, 5, 5);
> -			dmi_min_max_mask_uint8_check(fw, table, addr, "Base Addr Modifier/Interrupt Info)", hdr, 0x10, 0x0, 0x3, 6, 0x3);
> +			dmi_min_max_mask_uint8_check(fw, table, addr, "Base Addr Modifier/Interrupt Info)", hdr, 0x10, 0x0, 0x4, 6, 0x3);
>  			break;
>  
>  		case 39: /* 7.40 */
> 
Nice catch! Thanks

Acked-by: Colin Ian King <colin.king@canonical.com>

Patch

diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
index c0e78f0..0db787f 100644
--- a/src/dmi/dmicheck/dmicheck.c
+++ b/src/dmi/dmicheck/dmicheck.c
@@ -1772,7 +1772,7 @@  static void dmicheck_entry(fwts_framework *fw,
 
 			dmi_reserved_bits_check(fw, table, addr, "Base Addr Modifier/Interrupt Info", hdr, sizeof(uint8_t), 0x10, 2, 2);
 			dmi_reserved_bits_check(fw, table, addr, "Base Addr Modifier/Interrupt Info", hdr, sizeof(uint8_t), 0x10, 5, 5);
-			dmi_min_max_mask_uint8_check(fw, table, addr, "Base Addr Modifier/Interrupt Info)", hdr, 0x10, 0x0, 0x3, 6, 0x3);
+			dmi_min_max_mask_uint8_check(fw, table, addr, "Base Addr Modifier/Interrupt Info)", hdr, 0x10, 0x0, 0x4, 6, 0x3);
 			break;
 
 		case 39: /* 7.40 */