xtensa: fix PR target/82181

Message ID 1505164603-25715-1-git-send-email-jcmvbkbc@gmail.com
State New
Headers show
Series
  • xtensa: fix PR target/82181
Related show

Commit Message

Max Filippov Sept. 11, 2017, 9:16 p.m.
2017-09-11  Max Filippov  <jcmvbkbc@gmail.com>
gcc/
	* config/xtensa/xtensa.c (xtensa_mem_offset): Check that both
	words of E_DImode object are reachable by xtensa_uimm8x4 access.
---
 gcc/config/xtensa/xtensa.c | 1 +
 1 file changed, 1 insertion(+)

Comments

augustine.sterling@gmail.com Sept. 11, 2017, 9:18 p.m. | #1
On Mon, Sep 11, 2017 at 2:16 PM, Max Filippov <jcmvbkbc@gmail.com> wrote:
> 2017-09-11  Max Filippov  <jcmvbkbc@gmail.com>
> gcc/
>         * config/xtensa/xtensa.c (xtensa_mem_offset): Check that both
>         words of E_DImode object are reachable by xtensa_uimm8x4 access.

Approved. Please apply.
Max Filippov Sept. 11, 2017, 9:34 p.m. | #2
On Mon, Sep 11, 2017 at 2:18 PM, augustine.sterling@gmail.com
<augustine.sterling@gmail.com> wrote:
> On Mon, Sep 11, 2017 at 2:16 PM, Max Filippov <jcmvbkbc@gmail.com> wrote:
>> 2017-09-11  Max Filippov  <jcmvbkbc@gmail.com>
>> gcc/
>>         * config/xtensa/xtensa.c (xtensa_mem_offset): Check that both
>>         words of E_DImode object are reachable by xtensa_uimm8x4 access.
>
> Approved. Please apply.

Applied to trunk, thanks.
I will also backport the fix to 5.x, 6.x and 7.x branches.

-- Max

Patch

diff --git a/gcc/config/xtensa/xtensa.c b/gcc/config/xtensa/xtensa.c
index f7ce08478aa2..0f84cf3a7a04 100644
--- a/gcc/config/xtensa/xtensa.c
+++ b/gcc/config/xtensa/xtensa.c
@@ -615,6 +615,7 @@  xtensa_mem_offset (unsigned v, machine_mode mode)
     case E_HImode:
       return xtensa_uimm8x2 (v);
 
+    case E_DImode:
     case E_DFmode:
       return (xtensa_uimm8x4 (v) && xtensa_uimm8x4 (v + 4));