From patchwork Mon Sep 11 21:10:56 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gregory Rose X-Patchwork-Id: 812619 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ZTkPiuEB"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3xrgcT130Nz9s8J for ; Tue, 12 Sep 2017 07:12:41 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id B77F6CAC; Mon, 11 Sep 2017 21:11:19 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 38DB9C82 for ; Mon, 11 Sep 2017 21:11:17 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-pg0-f66.google.com (mail-pg0-f66.google.com [74.125.83.66]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 099CAD3 for ; Mon, 11 Sep 2017 21:11:16 +0000 (UTC) Received: by mail-pg0-f66.google.com with SMTP id v82so5195958pgb.1 for ; Mon, 11 Sep 2017 14:11:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=yHqpAVnwZ5598nsvJT24Ki7ePIntNOD9TQ05S8Hu91s=; b=ZTkPiuEBUzKFzZkkEYnzhbjozjgHrex/UGUKgBWu356ZfuCX5+Glg+RQRhCCC7CpME EiNaM0eXLX4qS93upUfmF3nVjsUR9ASZQZxKr5jgLC92nhZ5ZMEGTMRXJ1JMQMgXT5p2 tpZSuhsXF2RPQN8F9Ceco88dgEYI3IIXk1JSPV5u1Y96FcXILyxJEPn/HfGUdmLrteNh v3SfApZkwXlPtt2Buv2Suk+QnY0EOZYcScugEYOaNSvUea7ATsPzNBQPmr053TItsvgM Ke5CdWz9Bzh9xWq/pAzDTG1hN5FnUp97rWXIRXJPGNgMbbSMNKYFaJGBKDn24ytvI41O gcyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=yHqpAVnwZ5598nsvJT24Ki7ePIntNOD9TQ05S8Hu91s=; b=j+sd7hN3D23ktlPn30OGYPnoi1UhI4sqiC0OglmfywRU9gwsrZP/QMTQw7py70dKJx 5woVpa8aBrASl2hTAp7UuSVfe+NcIDsb3q1vsaFYT2aMAejs88d0b9Eep3N7oJZl0fLm gi+f9EG6uvXKuBlLdRMN/7CNGxlMN69BRMSikxWsP8MQUX7vk4kblfzBtoAG+ghyyQe/ iixDi7QPFnDjsC7V+Cmxd0aYhxnIwx49/pFbr5hPvcNZRkKGIdaj8ktQHzxMTy/UlZ/8 J5nyq98M/m1yDz9ol29dATm+5RRFQ2zEbbrt2sk8i7zYUEBoyAG7hv6ImPFWT3bKt9qK IiWA== X-Gm-Message-State: AHPjjUj+BRLihA/UNdY7QCyv4ctcRfs2HwBFAF9KHjXqlm+3RQVYLBYS +28wHLthBuuezxZ1 X-Google-Smtp-Source: ADKCNb6q90Ft3GOCiVjSH05EBU0G1tqhb8K9ToR3L85RlRjd3R2VLhJ9ZHcjWKAJPgjPckRLFa6Bdw== X-Received: by 10.84.129.226 with SMTP id b89mr14709651plb.36.1505164276298; Mon, 11 Sep 2017 14:11:16 -0700 (PDT) Received: from gizo.domain (67-5-132-83.ptld.qwest.net. [67.5.132.83]) by smtp.gmail.com with ESMTPSA id q23sm6568745pfk.182.2017.09.11.14.11.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Sep 2017 14:11:15 -0700 (PDT) From: Greg Rose To: dev@openvswitch.org Date: Mon, 11 Sep 2017 14:10:56 -0700 Message-Id: <1505164269-9455-3-git-send-email-gvrose8192@gmail.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1505164269-9455-1-git-send-email-gvrose8192@gmail.com> References: <1505164269-9455-1-git-send-email-gvrose8192@gmail.com> X-Spam-Status: No, score=0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM autolearn=disabled version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: [ovs-dev] [PATCH V2 03/16] datapath: Optimize updating for OvS flow_stats. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org Upstream commit: commit c57c054eb5b1ccf230c49f736f7a018fcbc3e952 Author: Tonghao Zhang Date: Mon Jul 17 23:28:05 2017 -0700 openvswitch: Optimize updating for OvS flow_stats. In the ovs_flow_stats_update(), we only use the node var to alloc flow_stats struct. But this is not a common case, it is unnecessary to call the numa_node_id() everytime. This patch is not a bugfix, but there maybe a small increase. Signed-off-by: Tonghao Zhang Signed-off-by: David S. Miller Signed-off-by: Greg Rose --- datapath/flow.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/datapath/flow.c b/datapath/flow.c index 599b4e5..30e4d21 100644 --- a/datapath/flow.c +++ b/datapath/flow.c @@ -71,7 +71,6 @@ void ovs_flow_stats_update(struct sw_flow *flow, __be16 tcp_flags, const struct sk_buff *skb) { struct flow_stats *stats; - int node = numa_node_id(); int cpu = smp_processor_id(); int len = skb->len + (skb_vlan_tag_present(skb) ? VLAN_HLEN : 0); @@ -107,7 +106,7 @@ void ovs_flow_stats_update(struct sw_flow *flow, __be16 tcp_flags, __GFP_THISNODE | __GFP_NOWARN | __GFP_NOMEMALLOC, - node); + numa_node_id()); if (likely(new_stats)) { new_stats->used = jiffies; new_stats->packet_count = 1;