| Message ID | 20170911210129.5874-1-f4bug@amsat.org |
|---|---|
| State | New |
| Headers | show |
| Series | test-qga: add missing qemu-ga tool dependency | expand |
On Mon, Sep 11, 2017 at 11:02 PM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote: > this fixes running 'make check-unit' without running 'make all' beforehand: > > $ make check-unit > ... > GTESTER tests/test-qga > ** > ERROR:tests/test-qga.c:73:fixture_setup: assertion failed (error == NULL): > Failed to execute child process "/build/qemu/qemu-ga" (No such file or > directory) (g-exec-error-quark, 8) > make: *** [check-tests/test-qga] Error 1 > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> > --- > occured trying to split Travis jobs to run more/faster > > tests/Makefile.include | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tests/Makefile.include b/tests/Makefile.include > index fae5715e9c..59e027f6ea 100644 > --- a/tests/Makefile.include > +++ b/tests/Makefile.include > @@ -832,7 +832,8 @@ endif > qtest-obj-y = tests/libqtest.o $(test-util-obj-y) > $(check-qtest-y): $(qtest-obj-y) > > -tests/test-qga: tests/test-qga.o $(qtest-obj-y) > +tests/test-qga$(EXESUF): qemu-ga$(EXESUF) > +tests/test-qga$(EXESUF): tests/test-qga.o $(qtest-obj-y) > > SPEED = quick > GTESTER_OPTIONS = -k $(if $(V),--verbose,-q) > -- > 2.14.1 > > > -- Marc-André Lureau
On 11/09/2017 23:01, Philippe Mathieu-Daudé wrote: > this fixes running 'make check-unit' without running 'make all' beforehand: > > $ make check-unit > ... > GTESTER tests/test-qga > ** > ERROR:tests/test-qga.c:73:fixture_setup: assertion failed (error == NULL): Failed to execute child process "/build/qemu/qemu-ga" (No such file or directory) (g-exec-error-quark, 8) Queued, thanks. Paolo > make: *** [check-tests/test-qga] Error 1 > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > occured trying to split Travis jobs to run more/faster > > tests/Makefile.include | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tests/Makefile.include b/tests/Makefile.include > index fae5715e9c..59e027f6ea 100644 > --- a/tests/Makefile.include > +++ b/tests/Makefile.include > @@ -832,7 +832,8 @@ endif > qtest-obj-y = tests/libqtest.o $(test-util-obj-y) > $(check-qtest-y): $(qtest-obj-y) > > -tests/test-qga: tests/test-qga.o $(qtest-obj-y) > +tests/test-qga$(EXESUF): qemu-ga$(EXESUF) > +tests/test-qga$(EXESUF): tests/test-qga.o $(qtest-obj-y) > > SPEED = quick > GTESTER_OPTIONS = -k $(if $(V),--verbose,-q) >
diff --git a/tests/Makefile.include b/tests/Makefile.include index fae5715e9c..59e027f6ea 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -832,7 +832,8 @@ endif qtest-obj-y = tests/libqtest.o $(test-util-obj-y) $(check-qtest-y): $(qtest-obj-y) -tests/test-qga: tests/test-qga.o $(qtest-obj-y) +tests/test-qga$(EXESUF): qemu-ga$(EXESUF) +tests/test-qga$(EXESUF): tests/test-qga.o $(qtest-obj-y) SPEED = quick GTESTER_OPTIONS = -k $(if $(V),--verbose,-q)
this fixes running 'make check-unit' without running 'make all' beforehand: $ make check-unit ... GTESTER tests/test-qga ** ERROR:tests/test-qga.c:73:fixture_setup: assertion failed (error == NULL): Failed to execute child process "/build/qemu/qemu-ga" (No such file or directory) (g-exec-error-quark, 8) make: *** [check-tests/test-qga] Error 1 Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- occured trying to split Travis jobs to run more/faster tests/Makefile.include | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)