reset: Restrict RESET_HSDK_V1 to ARC_SOC_HSDK or COMPILE_TEST

Message ID 1505132528-27843-1-git-send-email-geert@linux-m68k.org
State New
Headers show
Series
  • reset: Restrict RESET_HSDK_V1 to ARC_SOC_HSDK or COMPILE_TEST
Related show

Commit Message

Geert Uytterhoeven Sept. 11, 2017, 12:22 p.m.
The HSDK reset driver is only useful when building for an ARC HSDK
platform.

While at it, drop the "default n", as that is the default.

Fixes: e0be864f14240cb1 ("ARC: reset: introduce HSDKv1 reset driver")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/reset/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Vineet Gupta Sept. 20, 2017, 12:24 a.m. | #1
On 09/11/2017 05:22 AM, Geert Uytterhoeven wrote:
> The HSDK reset driver is only useful when building for an ARC HSDK
> platform.
> 
> While at it, drop the "default n", as that is the default.
> 
> Fixes: e0be864f14240cb1 ("ARC: reset: introduce HSDKv1 reset driver")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
>   drivers/reset/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> index 52d5251660b9b51c..feea22c912ebf688 100644
> --- a/drivers/reset/Kconfig
> +++ b/drivers/reset/Kconfig
> @@ -36,7 +36,7 @@ config RESET_BERLIN
>   
>   config RESET_HSDK_V1
>   	bool "HSDK v1 Reset Driver"
> -	default n
> +	depends on ARC_SOC_HSDK || COMPILE_TEST
>   	help
>   	  This enables the reset controller driver for HSDK v1.
>   
> 

Philip, can u please pick this up - there would be conflict due to V1 rename - 
easy to fixup !

Thx,
-Vineet
Philipp Zabel Sept. 21, 2017, 10:46 a.m. | #2
Hi Geert,

On Mon, 2017-09-11 at 14:22 +0200, Geert Uytterhoeven wrote:
> The HSDK reset driver is only useful when building for an ARC HSDK
> platform.
> 
> While at it, drop the "default n", as that is the default.
> 
> Fixes: e0be864f14240cb1 ("ARC: reset: introduce HSDKv1 reset driver")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Thank you for the patch. I have rebased it onto the HSDK_V1 -> HSDK name
change on the reset/fixes branch.

regards
Philipp

Patch

diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
index 52d5251660b9b51c..feea22c912ebf688 100644
--- a/drivers/reset/Kconfig
+++ b/drivers/reset/Kconfig
@@ -36,7 +36,7 @@  config RESET_BERLIN
 
 config RESET_HSDK_V1
 	bool "HSDK v1 Reset Driver"
-	default n
+	depends on ARC_SOC_HSDK || COMPILE_TEST
 	help
 	  This enables the reset controller driver for HSDK v1.