From patchwork Mon Sep 11 09:41:56 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bin Meng X-Patchwork-Id: 812287 X-Patchwork-Delegate: cyrille.pitchen@atmel.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rU+T6WZ4"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="TBjMkYey"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3xrNGJ52kQz9s7G for ; Mon, 11 Sep 2017 19:40:56 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=hiy7xRehqT2sLNutJRYVjcNCSso2JhgIjh0URnxMR3A=; b=rU+T6WZ45cgZMgZUe/A/jY7w0n CWgH9TZVWs+GMLSxPer0bedDOh2u8gPT3wHGCQ6DIPSnzv6y78d8p7uktTXy2WQooYStu5/+wsVcS Eat+Ok6czQ85kN/hfnlRCjWVg1kIUPvAEmHdiXdfJoY9LpwPwLkv/ZqKn8cNbFWjLnvNPtagis4xq 5qcOl7/Ed4JYkcrE04kUBGSZlKlFd6H+cLJh9dDyWllhux80YZ/iV84uEbnFRrYFRx2sBhyxTwW0r bdPu6meMJYeXQ9sn+GTI9jLh1EthBo2TsS69z4GF0eZcWUr96m/XNt9emwwa288DEgZIcNqrHpiSa QnMjEKyQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1drLD2-00010z-IV; Mon, 11 Sep 2017 09:40:52 +0000 Received: from mail-it0-x242.google.com ([2607:f8b0:4001:c0b::242]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1drLAO-0006BD-7x for linux-mtd@lists.infradead.org; Mon, 11 Sep 2017 09:38:10 +0000 Received: by mail-it0-x242.google.com with SMTP id z81so3846925itb.5 for ; Mon, 11 Sep 2017 02:37:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=7BP8jfakeGIf8x9ytNPcJa3V/X72/ucBYjOjdIPEg0I=; b=TBjMkYeyV0XDDVi9/Z9A/qdDO9xSzHm/quio45/gO5oq83kdgatw2xQ0pfwixHdrlC N5OXut49vuLpS/2wlvAgDKQQw0MKvKGASkPFLAMaqQsDtGBVI37UD2hZ22bdqeu3nXMD VKyFr9x1yG5d6hgTO0aF3xAwGk5jl0rEpLHmZppYKLxBKqJjAgEzVlDRylo9m2wgoID1 3lxywekQeNEetE4avENeqFBq0XJdjoOU9Zd4l73G9SeFCsTZu3F5w8Y7NtwOD3XyALuK ZCDMfnGt+XchFvcHNJlK+iQDKHWqip3XuD6oB5BSAjnf9YW7f7yUsp3wkjbrrCyIsy7A voig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=7BP8jfakeGIf8x9ytNPcJa3V/X72/ucBYjOjdIPEg0I=; b=iWS3G5uDFucMW6KEkpU9LtjWF3upm5bM0Ks5zQRfehD+vr+ZQaM2VgozmyxDhuP3EH hCwx4RpbWBnCTU9nGFXzbXq0g2cYcvANckS2c+fm+qVNYt0U2H3Ddp4SP1mOaBK0yjm5 lXjaxdOWBSH+qVyNHUgiJK+s4l1g93TmWuz4RUgm3hexYkSiPgBYR/y+whzdGJYyyUBk K9K9WjbBVOdJMjNY02W0vl3M/gGKM5SivdgXLd43kGXFrHGhWdQg3NKV6jr2d7AViz2D 4U9EJW5sXrr5TejISk9sXqjMDsfHrNvcyDBn7OACYRa0yaAzCowpy/lnk9Od5EZWKZtA HJxw== X-Gm-Message-State: AHPjjUimWOSbvPvh+el6h/IV5JGJHbBK2+o847jxhXm6n3GblmcpSD5U 26LJRBTO3LQy4A== X-Google-Smtp-Source: AOwi7QC8qhmMfGl4iuP5nv4AxyoqCux75wF0o38f9jSWxrM4k7z0oQeuGJ9xy2E1F23ATnhBSvPq9g== X-Received: by 10.36.131.9 with SMTP id d9mr4228920ite.14.1505122670614; Mon, 11 Sep 2017 02:37:50 -0700 (PDT) Received: from ala-d2121-lx1.wrs.com (unknown-156-139.windriver.com. [147.11.156.139]) by smtp.gmail.com with ESMTPSA id s2sm4121069ioa.2.2017.09.11.02.37.48 (version=TLS1_1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 11 Sep 2017 02:37:49 -0700 (PDT) From: Bin Meng To: Mika Westerberg , Cyrille Pitchen , Marek Vasut , Boris Brezillon , Brian Norris , Richard Weinberger , David Woodhouse , linux-mtd , linux-kernel Subject: [PATCH v2 06/10] spi-nor: intel-spi: Remove 'Atomic Cycle Sequence' in intel_spi_write() Date: Mon, 11 Sep 2017 02:41:56 -0700 Message-Id: <1505122921-5534-7-git-send-email-bmeng.cn@gmail.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1505122921-5534-1-git-send-email-bmeng.cn@gmail.com> References: <1505122921-5534-1-git-send-email-bmeng.cn@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170911_023808_537728_335ECE08 X-CRM114-Status: UNSURE ( 8.63 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.0 (--) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-2.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:4001:c0b:0:0:0:242 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (bmeng.cn[at]gmail.com) -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefan Roese MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org So far intel_spi_write() uses the HW sequencer to do the write. But the HW sequencer register HSFSTS_CTL does not have such a field for 'Atomic Cycle Sequence', remove it. Signed-off-by: Bin Meng Acked-by: Mika Westerberg --- Changes in v2: None drivers/mtd/spi-nor/intel-spi.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/mtd/spi-nor/intel-spi.c b/drivers/mtd/spi-nor/intel-spi.c index d0237fe..757b9f1 100644 --- a/drivers/mtd/spi-nor/intel-spi.c +++ b/drivers/mtd/spi-nor/intel-spi.c @@ -572,11 +572,6 @@ static ssize_t intel_spi_write(struct spi_nor *nor, loff_t to, size_t len, val |= HSFSTS_CTL_AEL | HSFSTS_CTL_FCERR | HSFSTS_CTL_FDONE; val |= (block_size - 1) << HSFSTS_CTL_FDBC_SHIFT; val |= HSFSTS_CTL_FCYCLE_WRITE; - - /* Write enable */ - if (ispi->preopcodes[1] == SPINOR_OP_WREN) - val |= SSFSTS_CTL_SPOP; - val |= SSFSTS_CTL_ACS; writel(val, ispi->base + HSFSTS_CTL); ret = intel_spi_write_block(ispi, write_buf, block_size);