diff mbox series

[net] ipv6: sr: remove duplicate routing header type check

Message ID 20170910124539.13808-1-dlebrun@google.com
State Superseded, archived
Delegated to: David Miller
Headers show
Series [net] ipv6: sr: remove duplicate routing header type check | expand

Commit Message

David Lebrun Sept. 10, 2017, 12:45 p.m. UTC 
From: David Lebrun <dav.lebrun@gmail.com>

From: David Lebrun <dlebrun@google.com>

As seg6_validate_srh() already checks that the Routing Header type is
correct, it is not necessary to do it again in get_srh().

Fixes: 5829d70b ("ipv6: sr: fix get_srh() to comply with IPv6 standard "RFC 8200")
Signed-off-by: David Lebrun <dlebrun@google.com>
---
 net/ipv6/seg6_local.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

David Lebrun Sept. 10, 2017, 1:18 p.m. UTC | #1 
Please ignore this one, resending with proper From lines.

David
diff mbox series

Patch

diff --git a/net/ipv6/seg6_local.c b/net/ipv6/seg6_local.c
index 7ff54db..825b8e0 100644
--- a/net/ipv6/seg6_local.c
+++ b/net/ipv6/seg6_local.c
@@ -72,10 +72,6 @@  static struct ipv6_sr_hdr *get_srh(struct sk_buff *skb)
 
 	srh = (struct ipv6_sr_hdr *)(skb->data + srhoff);
 
-	/* make sure it's a Segment Routing header (Routing Type 4) */
-	if (srh->type != IPV6_SRCRT_TYPE_4)
-		return NULL;
-
 	len = (srh->hdrlen + 1) << 3;
 
 	if (!pskb_may_pull(skb, srhoff + len))