From patchwork Sun Sep 10 05:00:05 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roi Dayan X-Patchwork-Id: 812036 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3xqf5m2QQSz9sDB for ; Sun, 10 Sep 2017 15:01:00 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 1A4FA8E2; Sun, 10 Sep 2017 05:00:18 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 6AC00266 for ; Sun, 10 Sep 2017 05:00:16 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by smtp1.linuxfoundation.org (Postfix) with ESMTP id 43E96101 for ; Sun, 10 Sep 2017 05:00:14 +0000 (UTC) Received: from Internal Mail-Server by MTLPINE1 (envelope-from roid@mellanox.com) with ESMTPS (AES256-SHA encrypted); 10 Sep 2017 08:00:10 +0300 Received: from dev-r-vrt-189.mtr.labs.mlnx (dev-r-vrt-189.mtr.labs.mlnx [10.212.189.1]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id v8A509LC024019; Sun, 10 Sep 2017 08:00:09 +0300 From: Roi Dayan To: dev@openvswitch.org Date: Sun, 10 Sep 2017 08:00:05 +0300 Message-Id: <1505019607-63461-1-git-send-email-roid@mellanox.com> X-Mailer: git-send-email 2.7.5 X-Spam-Status: No, score=0.0 required=5.0 tests=RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=disabled version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Cc: Simon Horman Subject: [ovs-dev] [PATCH V2 0/2] fix odp parsing of set masked action X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org Hi, The first commit is a fix for parsing set masked action and the second commit is adding a test. Before the fix the addtion of the tests fails with the following: # make check TESTSUITEFLAGS=436 # ./tests/ovstest test-odp parse-actions < ./tests/testsuite.dir/0436/actions.txt > outact && diff -up ./tests/testsuite.dir/0436/actions.txt outact V1->V2: - Small refactor to comments Thanks, Roi Paul Blakey (2): lib/odp: Fix handling of set masked action in parse_odp_action tests/odp: Add set vlan test to odp testsuite lib/odp-util.c | 9 +++++++++ tests/odp.at | 5 +++++ 2 files changed, 14 insertions(+) --- ./tests/testsuite.dir/0436/actions.txt 2017-08-27 11:12:05.169261080 +0300 +++ outact 2017-08-27 11:20:21.175169197 +0300 @@ -47,11 +47,11 @@ set(ipv6(label=0,proto=10,hlimit=128)) set(ipv6(label=0/0xfff,proto=10,tclass=0x70/0x70)) set(ipv6(label=0)) set(icmpv6(type=1,code=2)) -set(vlan(vid=5)) +set(vlan(vid=5/0x0)) set(vlan(vid=3,pcp=5)) set(vlan(vid=3,pcp=5,cfi=0)) -set(vlan(vid=5/0x3)) -set(vlan(vid=5/0x1)),3 +set(vlan(vid=5/0x0)) +set(vlan(vid=5/0x0)),***6 leftover bytes*** (010003000000) push_vlan(vid=12,pcp=0) push_vlan(vid=13,pcp=5,cfi=0) push_vlan(tpid=0x9100,vid=13,pcp=5)