From patchwork Fri Sep 8 17:59:23 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Bodireddy, Bhanuprakash" X-Patchwork-Id: 811780 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3xplqX0wKWz9ryk for ; Sat, 9 Sep 2017 04:15:36 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 88D9CCA6; Fri, 8 Sep 2017 18:09:20 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 93EFDC90 for ; Fri, 8 Sep 2017 18:09:16 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 30C50420 for ; Fri, 8 Sep 2017 18:09:16 +0000 (UTC) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP; 08 Sep 2017 11:09:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos; i="5.42,362,1500966000"; d="scan'208"; a="1216435682" Received: from silpixa00393942.ir.intel.com (HELO silpixa00393942.ger.corp.intel.com) ([10.237.223.42]) by fmsmga002.fm.intel.com with ESMTP; 08 Sep 2017 11:09:13 -0700 From: Bhanuprakash Bodireddy To: dev@openvswitch.org Date: Fri, 8 Sep 2017 18:59:23 +0100 Message-Id: <1504893565-110166-12-git-send-email-bhanuprakash.bodireddy@intel.com> X-Mailer: git-send-email 2.4.11 In-Reply-To: <1504893565-110166-1-git-send-email-bhanuprakash.bodireddy@intel.com> References: <1504893565-110166-1-git-send-email-bhanuprakash.bodireddy@intel.com> X-Spam-Status: No, score=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD autolearn=disabled version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: [ovs-dev] [PATCH 11/13] ofproto: Reorder elements in ofproto_bundle_settings structure. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org By reordering elements in ofproto_bundle_settings structure, sum holes and pad bytes can be reduced. Before: structure size: 96, sum holes: 13, pad bytes: 7, cachelines:2 After : structure size: 80, sum holes: 4, pad bytes: 0, cachelines:2 Signed-off-by: Bhanuprakash Bodireddy --- ofproto/ofproto.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/ofproto/ofproto.h b/ofproto/ofproto.h index 9e35327..2a7c1f3 100644 --- a/ofproto/ofproto.h +++ b/ofproto/ofproto.h @@ -403,18 +403,17 @@ struct ofproto_bundle_settings { size_t n_slaves; enum port_vlan_mode vlan_mode; /* Selects mode for vlan and trunks */ + bool protected; /* Protected port mode */ + bool use_priority_tags; /* Use 802.1p tag for frames in VLAN 0? */ uint16_t qinq_ethtype; int vlan; /* VLAN VID, except for PORT_VLAN_TRUNK. */ unsigned long *trunks; /* vlan_bitmap, except for PORT_VLAN_ACCESS. */ unsigned long *cvlans; - bool use_priority_tags; /* Use 802.1p tag for frames in VLAN 0? */ struct bond_settings *bond; /* Must be nonnull iff if n_slaves > 1. */ struct lacp_settings *lacp; /* Nonnull to enable LACP. */ struct lacp_slave_settings *lacp_slaves; /* Array of n_slaves elements. */ - - bool protected; /* Protected port mode */ }; int ofproto_bundle_register(struct ofproto *, void *aux,