From patchwork Fri Sep 8 17:59:20 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Bodireddy, Bhanuprakash" X-Patchwork-Id: 811776 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3xplnS5NZ7z9sDB for ; Sat, 9 Sep 2017 04:13:48 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id B1681C7F; Fri, 8 Sep 2017 18:09:16 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 0FFD2C7A for ; Fri, 8 Sep 2017 18:09:12 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id CEA10E5 for ; Fri, 8 Sep 2017 18:09:11 +0000 (UTC) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP; 08 Sep 2017 11:09:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos; i="5.42,362,1500966000"; d="scan'208"; a="1216435669" Received: from silpixa00393942.ir.intel.com (HELO silpixa00393942.ger.corp.intel.com) ([10.237.223.42]) by fmsmga002.fm.intel.com with ESMTP; 08 Sep 2017 11:09:10 -0700 From: Bhanuprakash Bodireddy To: dev@openvswitch.org Date: Fri, 8 Sep 2017 18:59:20 +0100 Message-Id: <1504893565-110166-9-git-send-email-bhanuprakash.bodireddy@intel.com> X-Mailer: git-send-email 2.4.11 In-Reply-To: <1504893565-110166-1-git-send-email-bhanuprakash.bodireddy@intel.com> References: <1504893565-110166-1-git-send-email-bhanuprakash.bodireddy@intel.com> X-Spam-Status: No, score=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD autolearn=disabled version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: [ovs-dev] [PATCH 08/13] dpif-netdev: Reorder elements in dp_netdev_rxq structure. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org By reordering elements in dp_netdev_rxq structure, pad bytes and a hole can be removed. Before: structure size: 104, sum holes: 1, sum padbytes:4, cachelines:2 After : structure size: 96, sum holes: 0, sum padbytes:0, cachelines:2 Signed-off-by: Bhanuprakash Bodireddy --- lib/dpif-netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index 071ec14..b1ef0fb 100644 --- a/lib/dpif-netdev.c +++ b/lib/dpif-netdev.c @@ -366,6 +366,7 @@ struct dp_netdev_rxq { pinned. OVS_CORE_UNSPEC if the queue doesn't need to be pinned to a particular core. */ + unsigned intrvl_idx; /* Write index for 'cycles_intrvl'. */ struct dp_netdev_pmd_thread *pmd; /* pmd thread that polls this queue. */ /* Counters of cycles spent successfully polling and processing pkts. */ @@ -373,7 +374,6 @@ struct dp_netdev_rxq { /* We store PMD_RXQ_INTERVAL_MAX intervals of data for an rxq and then sum them to yield the cycles used for an rxq. */ atomic_ullong cycles_intrvl[PMD_RXQ_INTERVAL_MAX]; - unsigned intrvl_idx; /* Write index for 'cycles_intrvl'. */ }; /* A port in a netdev-based datapath. */