python-six: add host variant

Message ID 20170908141414.24801-1-julien.floret@6wind.com
State Superseded
Headers show
Series
  • python-six: add host variant
Related show

Commit Message

Julien Floret Sept. 8, 2017, 2:14 p.m.
From: Samuel Gauthier <samuel.gauthier@6wind.com>

Needed to build Open vSwitch >= 2.6.

Signed-off-by: Samuel Gauthier <samuel.gauthier@6wind.com>
Signed-off-by: Julien Floret <julien.floret@6wind.com>
---
 package/python-six/python-six.mk | 1 +
 1 file changed, 1 insertion(+)

Comments

Thomas Petazzoni Sept. 8, 2017, 9:21 p.m. | #1
Hello,

On Fri,  8 Sep 2017 16:14:14 +0200, Julien Floret wrote:
> From: Samuel Gauthier <samuel.gauthier@6wind.com>
> 
> Needed to build Open vSwitch >= 2.6.
> 
> Signed-off-by: Samuel Gauthier <samuel.gauthier@6wind.com>
> Signed-off-by: Julien Floret <julien.floret@6wind.com>

Do you plan to submit a patch adding Open vSwitch ?

Best regards,

Thomas
Julien Floret Sept. 11, 2017, 8:39 a.m. | #2
Hello Thomas,

2017-09-08 23:21 GMT+02:00 Thomas Petazzoni
<thomas.petazzoni@free-electrons.com>:
> Hello,
>
> On Fri,  8 Sep 2017 16:14:14 +0200, Julien Floret wrote:
>> From: Samuel Gauthier <samuel.gauthier@6wind.com>
>>
>> Needed to build Open vSwitch >= 2.6.
>>
>> Signed-off-by: Samuel Gauthier <samuel.gauthier@6wind.com>
>> Signed-off-by: Julien Floret <julien.floret@6wind.com>
>
> Do you plan to submit a patch adding Open vSwitch ?

Unfortunately I don't think so, our integration is too custom and far
from upstreamable...
Maybe we should introduce a Config.in.host option for explicitly
enabling python-six host variant for external packages, like it is
done e.g. in python-lxml?
Thomas Petazzoni Sept. 12, 2017, 3:07 p.m. | #3
Hello,

On Mon, 11 Sep 2017 10:39:04 +0200, Julien Floret wrote:

> > Do you plan to submit a patch adding Open vSwitch ?  
> 
> Unfortunately I don't think so, our integration is too custom and far
> from upstreamable...

OK.

> Maybe we should introduce a Config.in.host option for explicitly
> enabling python-six host variant for external packages, like it is
> done e.g. in python-lxml?

Yes, perhaps we should to that.

Thanks!

Thomas
Julien Floret Sept. 13, 2017, 12:26 p.m. | #4
2017-09-12 17:07 GMT+02:00 Thomas Petazzoni
<thomas.petazzoni@free-electrons.com>:
> Hello,
>
> On Mon, 11 Sep 2017 10:39:04 +0200, Julien Floret wrote:
>
>> > Do you plan to submit a patch adding Open vSwitch ?
>>
>> Unfortunately I don't think so, our integration is too custom and far
>> from upstreamable...
>
> OK.
>
>> Maybe we should introduce a Config.in.host option for explicitly
>> enabling python-six host variant for external packages, like it is
>> done e.g. in python-lxml?
>
> Yes, perhaps we should to that.
>
> Thanks!

OK, I will send a v2 with the Config.in.host option. Thanks.

Patch

diff --git a/package/python-six/python-six.mk b/package/python-six/python-six.mk
index 0edefe346fdb..850f9340d322 100644
--- a/package/python-six/python-six.mk
+++ b/package/python-six/python-six.mk
@@ -12,3 +12,4 @@  PYTHON_SIX_LICENSE = MIT
 PYTHON_SIX_LICENSE_FILES = LICENSE
 
 $(eval $(python-package))
+$(eval $(host-python-package))