[ovs-dev] fix the comment in struct ofbundle

Message ID CALttK1Rtbbt9ALea9sVK7XBhTrP=1X7FmN7zmVim6w88_zVTXQ@mail.gmail.com
State Accepted
Headers show
Series
  • [ovs-dev] fix the comment in struct ofbundle
Related show

Commit Message

duanjiong Sept. 8, 2017, 1:34 a.m.
From 415ad9ffdb57a012729bef4ff19d1dc7b5b4cbcd Mon Sep 17 00:00:00 2001
From: Duan Jiong <djduanjiong@gmail.com>
Date: Fri, 8 Sep 2017 09:30:31 +0800
Subject: [PATCH] fix the comment in struct ofbundle

the ovs_list ports should contain struct ofport_dpif

Signed-off-by: Duan Jiong <djduanjiong@gmail.com>
---
 ofproto/ofproto-dpif.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ben Pfaff Nov. 3, 2017, 7:20 p.m. | #1
On Fri, Sep 08, 2017 at 09:34:07AM +0800, Duan Jiong wrote:
> From 415ad9ffdb57a012729bef4ff19d1dc7b5b4cbcd Mon Sep 17 00:00:00 2001
> From: Duan Jiong <djduanjiong@gmail.com>
> Date: Fri, 8 Sep 2017 09:30:31 +0800
> Subject: [PATCH] fix the comment in struct ofbundle
> 
> the ovs_list ports should contain struct ofport_dpif
> 
> Signed-off-by: Duan Jiong <djduanjiong@gmail.com>

Thanks for the fix.  I applied this to master.

(I apologize that it took so long to review this.)

Patch

diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index 1a8e829..59927eb 100644
--- a/ofproto/ofproto-dpif.c
+++ b/ofproto/ofproto-dpif.c
@@ -92,7 +92,7 @@  struct ofbundle {
     char *name;                 /* Identifier for log messages. */

     /* Configuration. */
-    struct ovs_list ports;      /* Contains "struct ofport"s. */
+    struct ovs_list ports;      /* Contains "struct ofport_dpif"s. */
     enum port_vlan_mode vlan_mode; /* VLAN mode */
     uint16_t qinq_ethtype;
     int vlan;                   /* -1=trunk port, else a 12-bit VLAN ID. */