From patchwork Mon Jan 31 14:15:24 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rainer Orth X-Patchwork-Id: 81105 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 3B299B70E2 for ; Tue, 1 Feb 2011 01:16:08 +1100 (EST) Received: (qmail 17698 invoked by alias); 31 Jan 2011 14:16:07 -0000 Received: (qmail 17690 invoked by uid 22791); 31 Jan 2011 14:16:06 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL, BAYES_00, TW_AV, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from snape.CeBiTec.Uni-Bielefeld.DE (HELO smtp-relay.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 31 Jan 2011 14:16:02 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 4D7F274D for ; Mon, 31 Jan 2011 15:16:00 +0100 (CET) Received: from smtp-relay.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id QicpOMPQLHxL for ; Mon, 31 Jan 2011 15:15:29 +0100 (CET) Received: from manam.CeBiTec.Uni-Bielefeld.DE (manam.CeBiTec.Uni-Bielefeld.DE [129.70.161.120]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id 086E6747 for ; Mon, 31 Jan 2011 15:15:25 +0100 (CET) Received: (from ro@localhost) by manam.CeBiTec.Uni-Bielefeld.DE (8.14.4+Sun/8.14.4/Submit) id p0VEFOm9013154; Mon, 31 Jan 2011 15:15:24 +0100 (MET) From: Rainer Orth To: gcc-patches@gcc.gnu.org Subject: [testsuite] Fix dg-require-weak syntax in g++.dg/abi/mangle40.C Date: Mon, 31 Jan 2011 15:15:24 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (usg-unix-v) MIME-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org While testing a different patch, I noticed that there's a testcase that doesn't get the dg-require-* syntax right: those keyword require an argument, and is silently ignored if that is missing. There's a single testcase that is affected by this problem. Fixed by adding an empty argument, tested by running the appropriate runtest invocation with -v -v -v and checking that dg-require-weak was ignored before and is now honored. Installed as obvious. Rainer 2011-01-30 Rainer Orth * g++.dg/abi/mangle40.C: Pass "" to dg-require-weak. diff -r 3876a9487b26 gcc/testsuite/g++.dg/abi/mangle40.C --- a/gcc/testsuite/g++.dg/abi/mangle40.C Fri Jan 28 15:07:37 2011 +0000 +++ b/gcc/testsuite/g++.dg/abi/mangle40.C Sun Jan 30 12:29:44 2011 +0100 @@ -1,6 +1,6 @@ // PR c++/12909 // { dg-do compile { target i?86-*-* x86_64-*-* } } -// { dg-require-weak } +// { dg-require-weak "" } // { dg-require-alias "" } // { dg-options "-mavx -Wabi -fabi-version=2" } // { dg-final { scan-assembler "(weak|glob)\[^\n\]*_Z1fIDv4_fEvT_" } }