diff mbox series

[1/1] smcroute: bump to version 2.3.1

Message ID 20170907130908.22964-1-thomas.faivre@6wind.com
State Accepted
Headers show
Series [1/1] smcroute: bump to version 2.3.1 | expand

Commit Message

Thomas Faivre Sept. 7, 2017, 1:09 p.m. UTC 
Signed-off-by: Thomas Faivre <thomas.faivre@6wind.com>
---
 package/smcroute/smcroute.hash | 6 +++---
 package/smcroute/smcroute.mk   | 8 +++++++-
 2 files changed, 10 insertions(+), 4 deletions(-)

Comments

Thomas Petazzoni Sept. 9, 2017, 9:05 p.m. UTC | #1 
Hello,

On Thu,  7 Sep 2017 15:09:08 +0200, Thomas Faivre wrote:
> Signed-off-by: Thomas Faivre <thomas.faivre@6wind.com>

Since the patch is doing more than a version bump, it would have be
good to have a short note in the commit log about the added libcap
optional dependency (especially how it's related to the version bump).

> +ifeq ($(BR2_PACKAGE_LIBCAP),y)
> +SMCROUTE_DEPENDENCIES = libcap

We like to explicitly pass --with-libcap here, so I've adjusted your
patch accordingly.

Applied to master with those two nits fixed. Thanks!

Thomas
diff mbox series

Patch

diff --git a/package/smcroute/smcroute.hash b/package/smcroute/smcroute.hash
index e1483ec180..0487ef6cab 100644
--- a/package/smcroute/smcroute.hash
+++ b/package/smcroute/smcroute.hash
@@ -1,4 +1,4 @@ 
 # Locally generated
-sha256  cf344922b4298b94e53fa2db8f2b064bece60f75926966f330437dfcbd76d425  smcroute-2.1.1.tar.xz
-# From https://github.com/troglobit/smcroute/releases/download/2.1.1/smcroute-2.1.1.tar.xz.md5
-md5     cd9256577fe06beaf8da2eba1a02f953  smcroute-2.1.1.tar.xz
+sha256  cd6c5cc2edfa1348acb07ed026180ebfc8dd0f87153f5382cb27cb5557724c56  smcroute-2.3.1.tar.xz
+# From https://github.com/troglobit/smcroute/releases/download/2.3.1/smcroute-2.3.1.tar.xz.md5
+md5     d8080828b7730bffb86969afd2bf94cb  smcroute-2.3.1.tar.xz
diff --git a/package/smcroute/smcroute.mk b/package/smcroute/smcroute.mk
index 0dd39ea54a..134d378ee0 100644
--- a/package/smcroute/smcroute.mk
+++ b/package/smcroute/smcroute.mk
@@ -4,7 +4,7 @@ 
 #
 ################################################################################
 
-SMCROUTE_VERSION = 2.1.1
+SMCROUTE_VERSION = 2.3.1
 SMCROUTE_SOURCE = smcroute-$(SMCROUTE_VERSION).tar.xz
 SMCROUTE_SITE = https://github.com/troglobit/smcroute/releases/download/$(SMCROUTE_VERSION)
 SMCROUTE_LICENSE = GPL-2.0+
@@ -14,4 +14,10 @@  SMCROUTE_CONF_OPTS = ac_cv_func_setpgrp_void=yes
 #BUG:The package Makefile uses CC?= even though the package is autotools based
 SMCROUTE_MAKE_ENV = $(TARGET_CONFIGURE_OPTS)
 
+ifeq ($(BR2_PACKAGE_LIBCAP),y)
+SMCROUTE_DEPENDENCIES = libcap
+else
+SMCROUTE_CONF_OPTS += --without-libcap
+endif
+
 $(eval $(autotools-package))