diff mbox series

[3/3] lan78xx: Use default value loaded from EEPROM/OTP when resetting

Message ID CE371C1263339941885964188A0225FA333A8D@CHN-SV-EXMX03.mchp-main.com
State Changes Requested, archived
Delegated to: David Miller
Headers show
Series None | expand

Commit Message

Nisar Sayed Sept. 7, 2017, 7:11 a.m. UTC 
From: Nisar Sayed <Nisar.Sayed@microchip.com>

Use default value loaded from EEPROM/OTP when resetting

Signed-off-by: Nisar Sayed <Nisar.Sayed@microchip.com>
---
 drivers/net/usb/lan78xx.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Andrew Lunn Sept. 7, 2017, 2:13 p.m. UTC | #1 
On Thu, Sep 07, 2017 at 07:11:50AM +0000, Nisar.Sayed@microchip.com wrote:
> From: Nisar Sayed <Nisar.Sayed@microchip.com>
> 
> Use default value loaded from EEPROM/OTP when resetting

Hi Nisar

Subject: [PATCH 3/3]

Is this a fix for net, or further development for net-next?

Why do we want the default values?

    Andrew
Nisar Sayed Sept. 8, 2017, 9:11 a.m. UTC | #2 
> On Thu, Sep 07, 2017 at 07:11:50AM +0000, Nisar.Sayed@microchip.com
> wrote:
> > From: Nisar Sayed <Nisar.Sayed@microchip.com>
> >
> > Use default value loaded from EEPROM/OTP when resetting
> 
> Hi Nisar
> 
> Subject: [PATCH 3/3]
> 
> Is this a fix for net, or further development for net-next?
> 
> Why do we want the default values?
> 
>     Andrew

Thanks Andrew,

Yes it is for "net", sorry missed to include it, will update in next version of submit.

These bits are "reset protected" and should not be modified and must use the
Must be configured from EEPROM only. Will update the description.

- Nisar
diff mbox series

Patch

diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c
index 94ef943..8fd7c2f 100644
--- a/drivers/net/usb/lan78xx.c
+++ b/drivers/net/usb/lan78xx.c
@@ -2452,7 +2452,6 @@  static int lan78xx_reset(struct lan78xx_net *dev)
 	/* LAN7801 only has RGMII mode */
 	if (dev->chipid == ID_REV_CHIP_ID_7801_)
 		buf &= ~MAC_CR_GMII_EN_;
-	buf |= MAC_CR_AUTO_DUPLEX_ | MAC_CR_AUTO_SPEED_;
 	ret = lan78xx_write_reg(dev, MAC_CR, buf);
 
 	ret = lan78xx_read_reg(dev, MAC_TX, &buf);