Patchwork gcj/classpath cosmetic configure improvement

login
register
mail settings
Submitter Alexandre Oliva
Date Jan. 31, 2011, 5:32 a.m.
Message ID <orhbcpy6xg.fsf@livre.localdomain>
Download mbox | patch
Permalink /patch/81080/
State New
Headers show

Comments

Alexandre Oliva - Jan. 31, 2011, 5:32 a.m.
I noticed by accident that classpath's configure printed “no: command
not found”.  It turned out that “no” isn't a very good command to pass
to AM_CONDITIONAL, because although it works, it's a bit noisy.  I
changed it to false, that should have the same effect, except that it
won't be noisy on most systems.

I'm checking this in at this point in the development cycle although it
doesn't fix any open bug reports and I have no idea whether it's a
regression just because it's such a trivial patch.

Tested on x86_64-linux-gnu.
Andrew Haley - Jan. 31, 2011, 9:50 a.m.
On 01/31/2011 05:32 AM, Alexandre Oliva wrote:
> I noticed by accident that classpath's configure printed “no: command
> not found”.  It turned out that “no” isn't a very good command to pass
> to AM_CONDITIONAL, because although it works, it's a bit noisy.  I
> changed it to false, that should have the same effect, except that it
> won't be noisy on most systems.
>
> I'm checking this in at this point in the development cycle although it
> doesn't fix any open bug reports and I have no idea whether it's a
> regression just because it's such a trivial patch.

OK,  but please also send to classpath.  We don't want divergences.

Andrew.

Patch

for  gcc/ChangeLog.gcj
from  Alexandre Oliva  <aoliva@redhat.com>

	* configure.ac (GCJ_JAVAC): Run false rather than no.
	* configure: Rebuilt.

Index: libjava/classpath/configure
===================================================================
--- libjava/classpath/configure.orig	2011-01-29 23:18:01.503129323 -0200
+++ libjava/classpath/configure	2011-01-29 23:19:30.004255023 -0200
@@ -24182,7 +24182,7 @@  $as_echo "no" >&6; }
 
 
 else
-    if no; then
+    if false; then
   GCJ_JAVAC_TRUE=
   GCJ_JAVAC_FALSE='#'
 else
Index: libjava/classpath/configure.ac
===================================================================
--- libjava/classpath/configure.ac.orig	2011-01-29 23:18:01.807129758 -0200
+++ libjava/classpath/configure.ac	2011-01-29 23:19:21.636243221 -0200
@@ -1076,7 +1076,7 @@  if test "x${use_glibj_zip}" = xfalse || 
 	AC_PROG_JAVAC_WORKS
   	CLASSPATH_JAVAC_MEM_CHECK
 else
-   AM_CONDITIONAL(GCJ_JAVAC, no)
+   AM_CONDITIONAL(GCJ_JAVAC, false)
 fi
 
 dnl -----------------------------------------------------------