Patchwork HEADS UP: [wwwdocs] Fix description of maintainer/reviewer privileges

login
register
mail settings
Submitter Gerald Pfeifer
Date Jan. 31, 2011, 1:02 a.m.
Message ID <alpine.LNX.2.00.1101310154330.14698@gerinyyl.fvgr>
Download mbox | patch
Permalink /patch/81068/
State New
Headers show

Comments

Gerald Pfeifer - Jan. 31, 2011, 1:02 a.m.
I realized that our documentation has not been adjusted to (not so)
recent changes and clarifications around the concepts of maintainers
and reviewers we use.  In fact, we don't have global maintainers any
more and introduced the concept of reviewers.

On the way I also tried to clarify that documentation web pages, and
testcases are covered by maintainership/reviewership in an area, too.

This is not supposed to constitute any change in policy.  Rather it
adjusts documentation thereof to reality.

I went ahead and committed the change.  If there is anything I missed
or that could be clarified, please advise!

Gerald
Jonathan Wakely - Jan. 31, 2011, 1:14 a.m.
On 31 January 2011 01:02, Gerald Pfeifer wrote:
>
>   <dt>Write after approval.</dt>
>   <dd><p>This is folks that make regular contributions, but do not
> -  fall into one of the two previous categories.  People with write
> +  fall into one of the previous categories.  People with write
>   after approval need to submit their patches to the list; once the
>   patches have been approved by the appropriate maintainers the
> -  patches may be checked into the GCC sources.  The steering committee
> +  patches may be checked in.  The steering committee
>   or a well-established GCC maintainer (including, but not limited to
>   global write maintainers) can <a href="#authenticated">
>   approve for write access</a> any person with GNU copyright assignment

Should this mention of global write maintainers be changed to global
reviewers too?

Patch

Index: svnwrite.html
===================================================================
RCS file: /cvs/gcc/wwwdocs/htdocs/svnwrite.html,v
retrieving revision 1.19
diff -u -r1.19 svnwrite.html
--- svnwrite.html	21 Dec 2009 08:22:31 -0000	1.19
+++ svnwrite.html	31 Jan 2011 00:59:12 -0000
@@ -92,39 +92,40 @@ 
 <hr />
 <h2><a name="policies">Write access policies</a></h2>
 
-<p>The GCC project grants some developers various levels of write
-access to the GCC master sources.  SVN doesn't provide fine grained
-control over access to the repository; therefore, we depend on each
-developer to follow the appropriate policies.</p>
+<p>The GCC project grants developers various levels of write access to
+and review authority over the GCC master sources.  We have not put any
+technical enforcement in place, rather we rely on everyone to follow
+the appropriate policies.</p>
 
 <dl>
-  <dt>Global write permission.</dt>
-  <dd><p>A very limited number of developers have global write
-  permission over the entire repository.  They may check in changes to
-  any part of the compiler without approval from anyone else.  They
-  may also approve other people's changes to any part of the
-  compiler.</p></dd>
+  <dt>Global reviewers.</dt>
+  <dd><p>A limited number of developers have global review permission
+  and can approve other people's changes to any part of the compiler.
+  </p></dd>
 
   <dt>Localized write permission.</dt>
   <dd><p>This is for people who have primary responsibility for ports,
-  front ends, or significant hunks of code in the compiler.  These
-  folks are allowed to make changes in code they maintain and
-  documentation related to that code without
-  approval from anyone else, and approve other people's changes in
-  those areas. They must get approval from the appropriate maintainers
-  for changes elsewhere in the compiler.</p>
-
-  <p>Maintainers of a port maintain the files in config/<i>port</i>/,
-  the configure fragments for the port, documentation for the port and
-  test cases for features or bugs specific to this port.  Port
-  maintainers do not have approval rights in other files.</p></dd>
+  front ends, or other specific aspects of the compiler.  These folks
+  are allowed to make changes to areas they maintain and related
+  documentation, web pages, and test cases without approval from
+  anyone else, and approve other people's changes in those areas. They
+  must get approval for changes elsewhere in the compiler.</p>
+
+  <p>Maintainers of a port maintain the relevant files in
+  <code>gcc/config</code>, documentation, web pages, and test cases
+  and aspects of these relevant to that port.  Port maintainers do
+  not have approval rights beyond this.</p></dd>
+
+  <dt>Localized review permission.</dt>
+  <dd><p>This is similar to localized write permission, except
+  that reviewers required approval for their own changes.</p></dd>
 
   <dt>Write after approval.</dt>
   <dd><p>This is folks that make regular contributions, but do not
-  fall into one of the two previous categories.  People with write
+  fall into one of the previous categories.  People with write
   after approval need to submit their patches to the list; once the
   patches have been approved by the appropriate maintainers the
-  patches may be checked into the GCC sources.  The steering committee
+  patches may be checked in.  The steering committee
   or a well-established GCC maintainer (including, but not limited to
   global write maintainers) can <a href="#authenticated">
   approve for write access</a> any person with GNU copyright assignment