pci: dwc: dra7xx: Add shutdown handler to cleanly turn off clocks

Message ID 1504694351-32358-1-git-send-email-j-keerthy@ti.com
State Superseded
Headers show
Series
  • pci: dwc: dra7xx: Add shutdown handler to cleanly turn off clocks
Related show

Commit Message

Keerthy Sept. 6, 2017, 10:39 a.m.
Add shutdown handler to cleanly turn off clocks.

Signed-off-by: Keerthy <j-keerthy@ti.com>
---
 drivers/pci/dwc/pci-dra7xx.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

Comments

Kishon Vijay Abraham I Sept. 6, 2017, 10:53 a.m. | #1
Keerthy,

On Wednesday 06 September 2017 04:09 PM, Keerthy wrote:
> Add shutdown handler to cleanly turn off clocks.

one minor comment below.. with that fixed you can add my

Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
> 
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
>  drivers/pci/dwc/pci-dra7xx.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
> index d4e98f3..66d1cfe 100644
> --- a/drivers/pci/dwc/pci-dra7xx.c
> +++ b/drivers/pci/dwc/pci-dra7xx.c
> @@ -874,6 +874,19 @@ static int dra7xx_pcie_suspend_noirq(struct device *dev)
>  	return 0;
>  }
>  
> +void dra7xx_pcie_shutdown(struct platform_device *pdev)
> +{
> +	struct dra7xx_pcie *dra7xx = dev_get_drvdata(&pdev->dev);

Use struct device *dev = &pdev->dev, instead of de-referencing device pointer
multiple times.

Thanks
Kishon
Kishon Vijay Abraham I Sept. 6, 2017, 10:56 a.m. | #2
On Wednesday 06 September 2017 04:23 PM, Kishon Vijay Abraham I wrote:
> Keerthy,
> 
> On Wednesday 06 September 2017 04:09 PM, Keerthy wrote:
>> Add shutdown handler to cleanly turn off clocks.
> 
> one minor comment below.. with that fixed you can add my
> 
> Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
>>
>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>> ---
>>  drivers/pci/dwc/pci-dra7xx.c | 14 ++++++++++++++
>>  1 file changed, 14 insertions(+)
>>
>> diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
>> index d4e98f3..66d1cfe 100644
>> --- a/drivers/pci/dwc/pci-dra7xx.c
>> +++ b/drivers/pci/dwc/pci-dra7xx.c
>> @@ -874,6 +874,19 @@ static int dra7xx_pcie_suspend_noirq(struct device *dev)
>>  	return 0;
>>  }
>>  
>> +void dra7xx_pcie_shutdown(struct platform_device *pdev)
>> +{
>> +	struct dra7xx_pcie *dra7xx = dev_get_drvdata(&pdev->dev);
> 
> Use struct device *dev = &pdev->dev, instead of de-referencing device pointer
> multiple times.

You might also have to dra7xx_pcie_stop_link() before disabling the clocks.

Thanks
Kishon
Keerthy Sept. 6, 2017, 12:59 p.m. | #3
On Wednesday 06 September 2017 04:26 PM, Kishon Vijay Abraham I wrote:
> 
> 
> On Wednesday 06 September 2017 04:23 PM, Kishon Vijay Abraham I wrote:
>> Keerthy,
>>
>> On Wednesday 06 September 2017 04:09 PM, Keerthy wrote:
>>> Add shutdown handler to cleanly turn off clocks.
>>
>> one minor comment below.. with that fixed you can add my
>>
>> Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
>>>
>>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>>> ---
>>>  drivers/pci/dwc/pci-dra7xx.c | 14 ++++++++++++++
>>>  1 file changed, 14 insertions(+)
>>>
>>> diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
>>> index d4e98f3..66d1cfe 100644
>>> --- a/drivers/pci/dwc/pci-dra7xx.c
>>> +++ b/drivers/pci/dwc/pci-dra7xx.c
>>> @@ -874,6 +874,19 @@ static int dra7xx_pcie_suspend_noirq(struct device *dev)
>>>  	return 0;
>>>  }
>>>  
>>> +void dra7xx_pcie_shutdown(struct platform_device *pdev)
>>> +{
>>> +	struct dra7xx_pcie *dra7xx = dev_get_drvdata(&pdev->dev);
>>
>> Use struct device *dev = &pdev->dev, instead of de-referencing device pointer
>> multiple times.
> 
> You might also have to dra7xx_pcie_stop_link() before disabling the clocks.

Thanks for the quick review. I will incorporate the above comments and
post v2.

Regards,
Keerthy

> 
> Thanks
> Kishon
>

Patch

diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
index d4e98f3..66d1cfe 100644
--- a/drivers/pci/dwc/pci-dra7xx.c
+++ b/drivers/pci/dwc/pci-dra7xx.c
@@ -874,6 +874,19 @@  static int dra7xx_pcie_suspend_noirq(struct device *dev)
 	return 0;
 }
 
+void dra7xx_pcie_shutdown(struct platform_device *pdev)
+{
+	struct dra7xx_pcie *dra7xx = dev_get_drvdata(&pdev->dev);
+	int ret;
+
+	ret = pm_runtime_put_sync(&pdev->dev);
+	if (ret < 0)
+		dev_dbg(&pdev->dev, "pm_runtime_put_sync failed\n");
+
+	pm_runtime_disable(&pdev->dev);
+	dra7xx_pcie_disable_phy(dra7xx);
+}
+
 static int dra7xx_pcie_resume_noirq(struct device *dev)
 {
 	struct dra7xx_pcie *dra7xx = dev_get_drvdata(dev);
@@ -902,5 +915,6 @@  static int dra7xx_pcie_resume_noirq(struct device *dev)
 		.suppress_bind_attrs = true,
 		.pm	= &dra7xx_pcie_pm_ops,
 	},
+	.shutdown = dra7xx_pcie_shutdown,
 };
 builtin_platform_driver_probe(dra7xx_pcie_driver, dra7xx_pcie_probe);