diff mbox series

tipc: remove unnecessary call to dev_net()

Message ID 20170906090806.20931-1-kleber.souza@canonical.com
State Accepted, archived
Delegated to: David Miller
Headers show
Series tipc: remove unnecessary call to dev_net() | expand

Commit Message

Kleber Sacilotto de Souza Sept. 6, 2017, 9:08 a.m. UTC
The net device is already stored in the 'net' variable, so no need to call
dev_net() again.

Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
---
 net/tipc/bearer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ying Xue Sept. 6, 2017, 12:50 p.m. UTC | #1
On 09/06/2017 05:08 PM, Kleber Sacilotto de Souza wrote:
> The net device is already stored in the 'net' variable, so no need to call
> dev_net() again.
> 
> Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>

Acked-by: Ying Xue <ying.xue@windriver.com>

> ---
>  net/tipc/bearer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/tipc/bearer.c b/net/tipc/bearer.c
> index 89cd061c4468..6d6395e0904e 100644
> --- a/net/tipc/bearer.c
> +++ b/net/tipc/bearer.c
> @@ -661,7 +661,7 @@ static int tipc_l2_device_event(struct notifier_block *nb, unsigned long evt,
>  		break;
>  	case NETDEV_UNREGISTER:
>  	case NETDEV_CHANGENAME:
> -		bearer_disable(dev_net(dev), b);
> +		bearer_disable(net, b);
>  		break;
>  	}
>  	return NOTIFY_OK;
>
David Miller Sept. 7, 2017, 4:26 a.m. UTC | #2
From: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
Date: Wed,  6 Sep 2017 11:08:06 +0200

> The net device is already stored in the 'net' variable, so no need to call
> dev_net() again.
> 
> Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/net/tipc/bearer.c b/net/tipc/bearer.c
index 89cd061c4468..6d6395e0904e 100644
--- a/net/tipc/bearer.c
+++ b/net/tipc/bearer.c
@@ -661,7 +661,7 @@  static int tipc_l2_device_event(struct notifier_block *nb, unsigned long evt,
 		break;
 	case NETDEV_UNREGISTER:
 	case NETDEV_CHANGENAME:
-		bearer_disable(dev_net(dev), b);
+		bearer_disable(net, b);
 		break;
 	}
 	return NOTIFY_OK;