| Submitter | Tobias Burnus |
|---|---|
| Date | Jan. 30, 2011, 5:48 p.m. |
| Message ID | <4D45A450.9020505@net-b.de> |
| Download | mbox | patch |
| Permalink | /patch/81039/ |
| State | New |
| Headers | show |
Comments
On Sun, Jan 30, 2011 at 06:48:00PM +0100, Tobias Burnus wrote: > Statement functions with pointer or allocatable attribute seem to be > invalid - thus, reject them. > > Build and regtested on x86-64-linux. > OK for the trunk? > > Tobias > > PS: gfortran, g95 and pgf95 did accept statement function with pointer > attribute (cf. example in the PR) - though it is rather unclear how they > could be handled. Other compilers (pathscale, NAG, ifort) reject them - > and F77 did not support POINTER thus I think one can reject it > unconditionally. OK. I agree with Nick. A statement function has an implicit interface. A procedure that returns a pointer or allocatable must have an explicit interface. Yes, I know there is the "other than a statement function" clause in 12.4.2.2 "Explicit interface". Thanks for the patch.
Patch
2011-01-31 Tobias Burnus <burnus@net-b.de>
PR fortran/47042
* resolve.c (resolve_fl_procedure): Reject stmt functions
with pointer/allocatable attribute.
2011-01-31 Tobias Burnus <burnus@net-b.de>
PR fortran/47042
* gfortran.dg/stmt_func_1.f90: New.
diff --git a/gcc/fortran/resolve.c b/gcc/fortran/resolve.c
index 55b5183..20be0d1 100644
--- a/gcc/fortran/resolve.c
+++ b/gcc/fortran/resolve.c
@@ -10231,6 +10231,14 @@ resolve_fl_procedure (gfc_symbol *sym, int mp_flag)
return FAILURE;
}
+ if (sym->attr.proc == PROC_ST_FUNCTION
+ && (sym->attr.allocatable || sym->attr.pointer))
+ {
+ gfc_error ("Statement function '%s' at %L may not have pointer or "
+ "allocatable attribute", sym->name, &sym->declared_at);
+ return FAILURE;
+ }
+
/* 5.1.1.5 of the Standard: A function name declared with an asterisk
char-len-param shall not be array-valued, pointer-valued, recursive
or pure. ....snip... A character value of * may only be used in the
--- /dev/null 2011-01-30 09:39:30.783999991 +0100
+++ gcc/gcc/testsuite/gfortran.dg/stmt_func_1.f90 2011-01-30 18:12:22.000000000 +0100
@@ -0,0 +1,12 @@
+! { dg-compile }
+! { dg-options "" }
+!
+! PR fortran/47542
+!
+integer, target, save :: tgt = 77
+integer, pointer ::ptr_stmt ! { dg-error "Statement function .ptr_stmt. at .1. may not have pointer or allocatable attribute" }
+integer, allocatable :: alloc_stmt ! { dg-error "Statement function .alloc_stmt. at .1. may not have pointer or allocatable attribute" }
+
+ptr_stmt() = tgt
+alloc_stmt() = 78
+end