From patchwork Tue Sep 5 09:24:15 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 810038 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-cifs-owner@vger.kernel.org; receiver=) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3xmhCn6zY9z9s0g for ; Tue, 5 Sep 2017 19:25:57 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750718AbdIEJZ4 (ORCPT ); Tue, 5 Sep 2017 05:25:56 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:59108 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750707AbdIEJZz (ORCPT ); Tue, 5 Sep 2017 05:25:55 -0400 Received: from wuerfel.lan ([95.208.190.237]) by mrelayeu.kundenserver.de (mreue001 [212.227.15.129]) with ESMTPA (Nemesis) id 0LmzUL-1dHTpn3O1N-00hPDb; Tue, 05 Sep 2017 11:24:42 +0200 From: Arnd Bergmann To: Steve French Cc: Arnd Bergmann , Pavel Shilovsky , Sachin Prabhu , Aurelien Aptel , Ronnie Sahlberg , linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org Subject: [PATCH] cifs: hide unused functions Date: Tue, 5 Sep 2017 11:24:15 +0200 Message-Id: <20170905092440.2172429-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:mQaZhahmtM1XG38IopTuwmdx0vYm1aiDioAC0l/h7cTy/Ubrl0Z HXKxA+4kkQ2WslV0YzTAtIAqE+82qEmF8+SjxClkdUcDed6xOSewkn7mUNMQH3E4TOLmLQx t8584ndvWU98mNG9N3bxBkWIcH/3nTCyHgMZL0w3CtGO+B3EONRnCfFwcIpcrGzirr/Y30U 2JsSyhOBpJkjBqinGLXSQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:tgSRTknfqes=:Eap+cQvXPVBaLDlFL9ToSF i1vpIqBH9+tmrcB4XdFrl5itM24guyfobFLXNHvtPxTSKke2TQGz/dlYN1utim0pTWuN+m3gd pEx8M/4qWVr+ayTju2/DKKB9x6rpTwhkAOux9d0P86uZFKofHB1dInXcxhV1UDboUKLhMuzDa 1xsjGeD3ccm0bYpchu7WLRjUtf1Yfk5RTmEkc2+GnSsqqoDa1oEbLl8vMHXA/FU7jKgsfwOxv ALQ4A1/YrCRDHgSSoXd+8rjAcvQb4XooWr789ql016KT/R74GtdhBdwl95KM61s9dd4kjrTIC Zq2i51zEBDBPFIW2it090M2KQScOOfw3NJ3dMclnp41n8+aMgbvj5ILexs9jwaecUc1mEMo7P PyAGzACh94DqWfuQ0DIscRgxnVexVizJtdJgazZGmmg8f7/CEblzEd7PbMU5uvBvrtfE++Thb 6nrMgn8oIl5hhc0qo2g7OV6BUR8rT9TSNlAXPEF6k/NUirx6RQ5Narmq2+f4aPdKsUCbYdftU 5fI9uINJswzfJhom7d/6MjarGfRO6pkaS40yeqn6Wqx3qvfTb5rvtSj37j6SY2V/qIMwACXtC TwDz8Og9St6i01uzpN+FID+g0V4cfSXB2ec3kBK7YMxvkCkLNGZ+Cy4WG+ZyJkozUaWVPk4yK zZTydmFq+5SbZJ/Qje2TxMGmUhoIuLVvjdJPqTpLMu+Wfd1ZOWpfa2f70imoY/HHY+B/vNLc/ TJkBlXLeBMJxDlvW5iuzBG3Hd7MQJBnT907tOw== Sender: linux-cifs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org The newly added SMB2+ attribute support causes unused function warnings when CONFIG_CIFS_XATTR is disabled: fs/cifs/smb2ops.c:563:1: error: 'smb2_set_ea' defined but not used [-Werror=unused-function] smb2_set_ea(const unsigned int xid, struct cifs_tcon *tcon, fs/cifs/smb2ops.c:513:1: error: 'smb2_query_eas' defined but not used [-Werror=unused-function] smb2_query_eas(const unsigned int xid, struct cifs_tcon *tcon, This adds another #ifdef around the affected functions. Fixes: 5517554e4313 ("cifs: Add support for writing attributes on SMB2+") Fixes: 95907fea4fd8 ("cifs: Add support for reading attributes on SMB2+") Signed-off-by: Arnd Bergmann Acked-by: Geert Uytterhoeven --- fs/cifs/smb2ops.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c index fb2934b9b97c..6cd91670ba2d 100644 --- a/fs/cifs/smb2ops.c +++ b/fs/cifs/smb2ops.c @@ -426,6 +426,7 @@ smb2_query_file_info(const unsigned int xid, struct cifs_tcon *tcon, return rc; } +#ifdef CONFIG_CIFS_XATTR static ssize_t move_smb2_ea_to_cifs(char *dst, size_t dst_size, struct smb2_file_full_ea_info *src, size_t src_size, @@ -613,6 +614,7 @@ smb2_set_ea(const unsigned int xid, struct cifs_tcon *tcon, return rc; } +#endif static bool smb2_can_echo(struct TCP_Server_Info *server)