| Message ID | 20170904154316.4148-6-david@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | s390x cleanups and CPU hotplug via device_add | expand |
On Mon, 4 Sep 2017 17:43:02 +0200 David Hildenbrand <david@redhat.com> wrote: > Let's move it to the palce where struct S390CPU is defined. s/palce/place/ Can also fix on applying. > > Suggested-by: Thomas Huth <thuth@redhat.com> > Signed-off-by: David Hildenbrand <david@redhat.com> > --- > target/s390x/cpu-qom.h | 2 -- > target/s390x/cpu.h | 4 ++-- > 2 files changed, 2 insertions(+), 4 deletions(-)
On 04.09.2017 17:43, David Hildenbrand wrote: > Let's move it to the palce where struct S390CPU is defined. s/palce/place/ > Suggested-by: Thomas Huth <thuth@redhat.com> > Signed-off-by: David Hildenbrand <david@redhat.com> > --- > target/s390x/cpu-qom.h | 2 -- > target/s390x/cpu.h | 4 ++-- > 2 files changed, 2 insertions(+), 4 deletions(-) Seems to compile fine for me with this patch applied, so: Tested-by: Thomas Huth <thuth@redhat.com>
diff --git a/target/s390x/cpu-qom.h b/target/s390x/cpu-qom.h index 4e936e7788..c8fbf8ae03 100644 --- a/target/s390x/cpu-qom.h +++ b/target/s390x/cpu-qom.h @@ -61,6 +61,4 @@ typedef struct S390CPUClass { void (*initial_cpu_reset)(CPUState *cpu); } S390CPUClass; -typedef struct S390CPU S390CPU; - #endif diff --git a/target/s390x/cpu.h b/target/s390x/cpu.h index 0bd97a5670..a7426ef6e2 100644 --- a/target/s390x/cpu.h +++ b/target/s390x/cpu.h @@ -187,7 +187,7 @@ static inline CPU_DoubleU *get_freg(CPUS390XState *cs, int nr) * * An S/390 CPU. */ -struct S390CPU { +typedef struct S390CPU { /*< private >*/ CPUState parent_obj; /*< public >*/ @@ -198,7 +198,7 @@ struct S390CPU { /* needed for live migration */ void *irqstate; uint32_t irqstate_saved_size; -}; +} S390CPU; static inline S390CPU *s390_env_get_cpu(CPUS390XState *env) {
Let's move it to the palce where struct S390CPU is defined. Suggested-by: Thomas Huth <thuth@redhat.com> Signed-off-by: David Hildenbrand <david@redhat.com> --- target/s390x/cpu-qom.h | 2 -- target/s390x/cpu.h | 4 ++-- 2 files changed, 2 insertions(+), 4 deletions(-)