diff mbox series

uefi: uefirttime: constify static array dayofmonth

Message ID 20170904131601.19434-1-colin.king@canonical.com
State Accepted
Headers show
Series uefi: uefirttime: constify static array dayofmonth | expand

Commit Message

Colin Ian King Sept. 4, 2017, 1:16 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

The static and read-only array can also be made const

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/uefi/uefirttime/uefirttime.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alex Hung Sept. 5, 2017, 5:31 a.m. UTC | #1 
On 2017-09-04 06:16 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The static and read-only array can also be made const
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/uefi/uefirttime/uefirttime.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/uefi/uefirttime/uefirttime.c b/src/uefi/uefirttime/uefirttime.c
> index 621f53b6..7998f7fd 100644
> --- a/src/uefi/uefirttime/uefirttime.c
> +++ b/src/uefi/uefirttime/uefirttime.c
> @@ -36,7 +36,7 @@
>   		((year) % 4 == 0 && ((year) % 100 != 0 || (year) % 400 == 0))
>   
>   static int fd;
> -static uint32_t dayofmonth[12] = {31, 29, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31};
> +static const uint32_t dayofmonth[12] = { 31, 29, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31 };
>   
>   static bool dayvalid(EFI_TIME *Time)
>   {
> 


Acked-by: Alex Hung <alex.hung@canonical.com>
Ivan Hu Sept. 6, 2017, 8:22 a.m. UTC | #2 
On 09/04/2017 09:16 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The static and read-only array can also be made const
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/uefi/uefirttime/uefirttime.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/uefi/uefirttime/uefirttime.c b/src/uefi/uefirttime/uefirttime.c
> index 621f53b6..7998f7fd 100644
> --- a/src/uefi/uefirttime/uefirttime.c
> +++ b/src/uefi/uefirttime/uefirttime.c
> @@ -36,7 +36,7 @@
>   		((year) % 4 == 0 && ((year) % 100 != 0 || (year) % 400 == 0))
>   
>   static int fd;
> -static uint32_t dayofmonth[12] = {31, 29, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31};
> +static const uint32_t dayofmonth[12] = { 31, 29, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31 };
>   
>   static bool dayvalid(EFI_TIME *Time)
>   {
> 

Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff mbox series

Patch

diff --git a/src/uefi/uefirttime/uefirttime.c b/src/uefi/uefirttime/uefirttime.c
index 621f53b6..7998f7fd 100644
--- a/src/uefi/uefirttime/uefirttime.c
+++ b/src/uefi/uefirttime/uefirttime.c
@@ -36,7 +36,7 @@ 
 		((year) % 4 == 0 && ((year) % 100 != 0 || (year) % 400 == 0))
 
 static int fd;
-static uint32_t dayofmonth[12] = {31, 29, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31};
+static const uint32_t dayofmonth[12] = { 31, 29, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31 };
 
 static bool dayvalid(EFI_TIME *Time)
 {