Patchwork [04/13] batman-adv: Remove vis info on hashing errors

login
register
mail settings
Submitter Sven Eckelmann
Date Jan. 29, 2011, 9:47 p.m.
Message ID <1296337660-12376-5-git-send-email-sven@narfation.org>
Download mbox | patch
Permalink /patch/80967/
State Changes Requested
Delegated to: David Miller
Headers show

Comments

Sven Eckelmann - Jan. 29, 2011, 9:47 p.m.
A newly created vis info object must be removed when it couldn't be
added to the hash. The old_info which has to be replaced was already
removed and isn't related to the hash anymore.

Signed-off-by: Sven Eckelmann <sven@narfation.org>
---
 net/batman-adv/vis.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Patch

diff --git a/net/batman-adv/vis.c b/net/batman-adv/vis.c
index f69a374..0be55be 100644
--- a/net/batman-adv/vis.c
+++ b/net/batman-adv/vis.c
@@ -444,7 +444,7 @@  static struct vis_info *add_packet(struct bat_priv *bat_priv,
 			      info);
 	if (hash_added < 0) {
 		/* did not work (for some reason) */
-		kref_put(&old_info->refcount, free_info);
+		kref_put(&info->refcount, free_info);
 		info = NULL;
 	}