[v6,2/3] eeprom: at24: add support to fetch eeprom device property "size"

Message ID 1504520928-5191-3-git-send-email-divagar.mohandass@intel.com
State New
Headers show
Series
  • enable eeprom "size" property and runtime pm
Related show

Commit Message

Mohandass, Divagar Sept. 4, 2017, 10:28 a.m.
Obtain the size of the EEPROM chip from DT if the "size" property is
specified for the device.

Signed-off-by: Divagar Mohandass <divagar.mohandass@intel.com>
---
 drivers/misc/eeprom/at24.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Mani, Rajmohan Sept. 20, 2017, 3:52 a.m. | #1
Adding Tomasz...

> -----Original Message-----
> From: Mohandass, Divagar
> Sent: Monday, September 04, 2017 3:29 AM
> To: robh+dt@kernel.org; mark.rutland@arm.com; wsa@the-dreams.de;
> sakari.ailus@iki.fi
> Cc: devicetree@vger.kernel.org; linux-i2c@vger.kernel.org; linux-
> kernel@vger.kernel.org; Mani, Rajmohan <rajmohan.mani@intel.com>;
> Mohandass, Divagar <divagar.mohandass@intel.com>
> Subject: [PATCH v6 2/3] eeprom: at24: add support to fetch eeprom device
> property "size"
> 
> Obtain the size of the EEPROM chip from DT if the "size" property is specified
> for the device.
> 
> Signed-off-by: Divagar Mohandass <divagar.mohandass@intel.com>
> ---
>  drivers/misc/eeprom/at24.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c index
> 764ff5df..2199c42 100644
> --- a/drivers/misc/eeprom/at24.c
> +++ b/drivers/misc/eeprom/at24.c
> @@ -570,6 +570,10 @@ static void at24_get_pdata(struct device *dev, struct
> at24_platform_data *chip)
>  	if (device_property_present(dev, "read-only"))
>  		chip->flags |= AT24_FLAG_READONLY;
> 
> +	err = device_property_read_u32(dev, "size", &val);
> +	if (!err)
> +		chip->byte_len = val;
> +
>  	err = device_property_read_u32(dev, "pagesize", &val);
>  	if (!err) {
>  		chip->page_size = val;
> --
> 1.9.1
Andy Shevchenko Sept. 22, 2017, 4:11 p.m. | #2
On Wed, Sep 20, 2017 at 6:52 AM, Mani, Rajmohan <rajmohan.mani@intel.com> wrote:
> Adding Tomasz...

Please, don't top post.
Better to resend entire series with all stakeholders included.

>> Obtain the size of the EEPROM chip from DT if the "size" property is specified
>> for the device.
>>

I guess it lacks
Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Other than that, looks good to me!

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>


Wolfram, the binding is ACKed by Rob and this one is in a good shape.
Moreover, it seems like a demand for the property since some IoT stuff
would like to use the driver on ACPI enabled platforms with different
sizes.

Can you go ahead and apply first two patches? It would be really appreciated.

>> Signed-off-by: Divagar Mohandass <divagar.mohandass@intel.com>
>> ---
>>  drivers/misc/eeprom/at24.c | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c index
>> 764ff5df..2199c42 100644
>> --- a/drivers/misc/eeprom/at24.c
>> +++ b/drivers/misc/eeprom/at24.c
>> @@ -570,6 +570,10 @@ static void at24_get_pdata(struct device *dev, struct
>> at24_platform_data *chip)
>>       if (device_property_present(dev, "read-only"))
>>               chip->flags |= AT24_FLAG_READONLY;
>>
>> +     err = device_property_read_u32(dev, "size", &val);
>> +     if (!err)
>> +             chip->byte_len = val;
>> +
>>       err = device_property_read_u32(dev, "pagesize", &val);
>>       if (!err) {
>>               chip->page_size = val;
>> --
>> 1.9.1
>

Patch

diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c
index 764ff5df..2199c42 100644
--- a/drivers/misc/eeprom/at24.c
+++ b/drivers/misc/eeprom/at24.c
@@ -570,6 +570,10 @@  static void at24_get_pdata(struct device *dev, struct at24_platform_data *chip)
 	if (device_property_present(dev, "read-only"))
 		chip->flags |= AT24_FLAG_READONLY;
 
+	err = device_property_read_u32(dev, "size", &val);
+	if (!err)
+		chip->byte_len = val;
+
 	err = device_property_read_u32(dev, "pagesize", &val);
 	if (!err) {
 		chip->page_size = val;