Patchwork [7/8] sparc32,sun4d: add comment in empty statement in sun4d_request_irq()

login
register
mail settings
Submitter Sam Ravnborg
Date Jan. 29, 2011, 8:08 a.m.
Message ID <1296288504-15933-7-git-send-email-sam@ravnborg.org>
Download mbox | patch
Permalink /patch/80930/
State Accepted
Delegated to: David Miller
Headers show

Comments

Sam Ravnborg - Jan. 29, 2011, 8:08 a.m.
This looked like a bug to me.
Add a comment so next reader is hopefully less confused.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 arch/sparc/kernel/sun4d_irq.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

Patch

diff --git a/arch/sparc/kernel/sun4d_irq.c b/arch/sparc/kernel/sun4d_irq.c
index b2e3fbf..609a13c 100644
--- a/arch/sparc/kernel/sun4d_irq.c
+++ b/arch/sparc/kernel/sun4d_irq.c
@@ -307,7 +307,8 @@  int sun4d_request_irq(unsigned int irq,
 
 	if (action) {
 		if ((action->flags & IRQF_SHARED) && (irqflags & IRQF_SHARED)) {
-			for (tmp = action; tmp->next; tmp = tmp->next);
+			for (tmp = action; tmp->next; tmp = tmp->next)
+				/* find last entry - tmp used below */;
 		} else {
 			ret = -EBUSY;
 			goto out_unlock;