From patchwork Sun Sep 3 09:53:51 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yann E. MORIN" X-Patchwork-Id: 809248 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.133; helo=hemlock.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="nIt/WvDA"; dkim-atps=neutral Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3xlSxK4839z9s76 for ; Sun, 3 Sep 2017 19:54:13 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 997BB88A27; Sun, 3 Sep 2017 09:54:08 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LxX3WDo5gpcN; Sun, 3 Sep 2017 09:54:04 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id 160F388516; Sun, 3 Sep 2017 09:54:04 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 2F68D1C41C7 for ; Sun, 3 Sep 2017 09:54:02 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 2700F8698D for ; Sun, 3 Sep 2017 09:54:02 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id V0K3KXaLg3wD for ; Sun, 3 Sep 2017 09:54:01 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 1DF438695E for ; Sun, 3 Sep 2017 09:54:01 +0000 (UTC) Received: by mail-wm0-f65.google.com with SMTP id l19so3887536wmi.1 for ; Sun, 03 Sep 2017 02:54:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=Btu9QG11UNPJDuQ6+oR/0C3vM6lhJxANeN1qTzNoxDs=; b=nIt/WvDArgIQuK0QzosBoMzhcWb1nT34TW8RQrqc/BqNb4/9FEgdVT31+NXiPQxSoN gQyrOQ/RT13hjbaRrcbiK0C9zT1Qe1vGFok0HydyhWzBvwVPyXkb1B7BLiQkFUsiSUwq u9tTke/Ob1Lbe9HgR1fgUb4+fH5SWh/hXPCPWSMJ9HlTu6bGTAHkfzgxsrrs87P+EmKQ g+JVyj1xCJR0ww7KPHKmz3OhijSKD/9MjDqPNRNIo9ThlrFOr/YInHpPAConqxXPAQlC dWo5cCliv9wqZRvAjJLu3ZQGQUdR87cXy7XzvY9fBBIo9tM/VKzMHKHVqj++N5VutMFq 1AGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=Btu9QG11UNPJDuQ6+oR/0C3vM6lhJxANeN1qTzNoxDs=; b=PUPfQnxKp/fhIT9WRV2f4TjHNgRCpGGWvtdjwK6tfimZOUefTG2W0j9ksAAMtXwd7M jJufmwv8hGWGyxa6SGb0CdAp7XJPdwLtyqCZLy5FBxyhyjOMb/GdYG3+NuaITUyBZipK 9LXO1ZiV0QgRdapUy3qEmGGplxyjQ5LWBUFQQHT99bLARimpCkoU1WIImEOZMqH34KyF 65Xn3mySN1IX61SLLblxOIZ7P1jHHl5OEP5nmRGV9oFwl8Bf37KcCXdjDop+PBkGND7x s8A/lUeEsKx6lpqlK/K63I8yShrc5Nb6sFU4cQ3FRSstRYO5Cin3PpIDROniM+yC+W/t dG7g== X-Gm-Message-State: AHPjjUiLKYWmBXQWQxGS8Jpaflf6Q0oWuzOhgufYZDFuSGE1sNxAhZQk kKIrTGmzBcOVrZs8 X-Google-Smtp-Source: ADKCNb4nvdmvlBPPwh0PAHXlD7W2/BoOMAvpDJzMn+PppHXUw60OGTA1WCfOO66fQPniX5kc0g/8IQ== X-Received: by 10.28.216.15 with SMTP id p15mr2480167wmg.161.1504432439397; Sun, 03 Sep 2017 02:53:59 -0700 (PDT) Received: from localhost.localdomain (2a01cb0886107300d49b0f6dfb1eb067.ipv6.abo.wanadoo.fr. [2a01:cb08:8610:7300:d49b:f6d:fb1e:b067]) by smtp.gmail.com with ESMTPSA id w16sm3777451wmw.2.2017.09.03.02.53.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 03 Sep 2017 02:53:56 -0700 (PDT) From: "Yann E. MORIN" To: buildroot@buildroot.org Date: Sun, 3 Sep 2017 11:53:51 +0200 Message-Id: <97a1396440baea0fec1c3fb6593d9cf7f3655f99.1504432422.git.yann.morin.1998@free.fr> X-Mailer: git-send-email 2.11.0 In-Reply-To: References: Cc: Thomas Petazzoni , "Yann E. MORIN" , Vicente Olivert Riera Subject: [Buildroot] [PATCH 2/3] arch/mips: inverse the mfpxx logic X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Currently, the possibility to choose the floating point mode (32, xx or 64) is conditional on having a sufficiently recent gcc version. Which means that the architecture selection depends on the gcc version. But that's opposite to what we've always done in Buildroot: the software versions are conditional to the architecture options. There is nothing we can do about the hardware: it is there, we can't change it, while we can restrict ourselves to using software that is working on said hardware. Thus, we inverse the logic, to move the condition onto the software side: whenever mfpxx is selected, we restrict the toolchain selection to at least a gcc-5. And now, the blind BR2_TOOLCHAIN_HAS_MFPXX_OPTION symbol is no longer needed, so we get rid of it. Signed-off-by: "Yann E. MORIN" Cc: Thomas Petazzoni Cc: Vicente Olivert Riera --- arch/Config.in.mips | 4 ++-- toolchain/toolchain-common.in | 4 ---- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/arch/Config.in.mips b/arch/Config.in.mips index 13d1a477e6..f8e57bab33 100644 --- a/arch/Config.in.mips +++ b/arch/Config.in.mips @@ -146,7 +146,7 @@ config BR2_MIPS_SOFT_FLOAT choice prompt "FP mode" depends on !BR2_ARCH_IS_64 && !BR2_MIPS_SOFT_FLOAT - default BR2_MIPS_FP32_MODE_XX if BR2_TOOLCHAIN_HAS_MFPXX_OPTION + default BR2_MIPS_FP32_MODE_XX help MIPS32 supports different FP modes (32,xx,64). Information about FP modes can be found here: @@ -159,7 +159,7 @@ config BR2_MIPS_FP32_MODE_32 config BR2_MIPS_FP32_MODE_XX bool "xx" - depends on BR2_TOOLCHAIN_HAS_MFPXX_OPTION + select BR2_ARCH_NEEDS_GCC_AT_LEAST_5 config BR2_MIPS_FP32_MODE_64 bool "64" diff --git a/toolchain/toolchain-common.in b/toolchain/toolchain-common.in index dd192b9ba4..0002682e12 100644 --- a/toolchain/toolchain-common.in +++ b/toolchain/toolchain-common.in @@ -346,10 +346,6 @@ config BR2_TOOLCHAIN_HAS_MNAN_OPTION bool default y if BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 -config BR2_TOOLCHAIN_HAS_MFPXX_OPTION - bool - default y if BR2_TOOLCHAIN_GCC_AT_LEAST_5 - config BR2_TOOLCHAIN_HAS_SYNC_1 bool default y