From patchwork Fri Jan 28 20:14:52 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ralf Wildenhues X-Patchwork-Id: 80888 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 06F2F1007D1 for ; Sat, 29 Jan 2011 07:15:08 +1100 (EST) Received: (qmail 11748 invoked by alias); 28 Jan 2011 20:15:05 -0000 Received: (qmail 11728 invoked by uid 22791); 28 Jan 2011 20:15:04 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from mailout-de.gmx.net (HELO mailout-de.gmx.net) (213.165.64.22) by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Fri, 28 Jan 2011 20:14:56 +0000 Received: (qmail invoked by alias); 28 Jan 2011 20:14:53 -0000 Received: from xdsl-89-0-182-62.netcologne.de (EHLO localhost.localdomain) [89.0.182.62] by mail.gmx.net (mp012) with SMTP; 28 Jan 2011 21:14:53 +0100 Received: from ralf by localhost.localdomain with local (Exim 4.69) (envelope-from ) id 1Piuia-0003AX-Hy; Fri, 28 Jan 2011 21:14:52 +0100 Date: Fri, 28 Jan 2011 21:14:52 +0100 From: Ralf Wildenhues To: Steve Ellcey , gcc-patches@gcc.gnu.org, Gerald Pfeifer Cc: binutils@sourceware.org, "H.J. Lu" Subject: PATCH: import move-if-change from gnulib (was: PATCH: PR binutils/12283: bfd/doc doesn't support parallel build) Message-ID: <20110128201452.GM7234@gmx.de> Mail-Followup-To: Ralf Wildenhues , Steve Ellcey , gcc-patches@gcc.gnu.org, Gerald Pfeifer , binutils@sourceware.org, "H.J. Lu" References: <201101272357.p0RNvPZ13996@lucas.cup.hp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <201101272357.p0RNvPZ13996@lucas.cup.hp.com> User-Agent: Mutt/1.5.20 (2010-08-04) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org [ adding gcc-patches ] * Steve Ellcey wrote on Fri, Jan 28, 2011 at 12:57:25AM CET: > I tried this patch and I think it works. Before patching I got: > > mv: cannot move `chew.13844' to `chew': Text file busy > make[3]: *** [chew] Error 1 > make[2]: *** [bfdt.texi] Error 2 > make[2]: *** Waiting for unfinished jobs.... > make[2]: *** Waiting for unfinished jobs.... > make[1]: *** [info-recursive] Error 1 > make: *** [all-bfd] Error 2 > > After applying the patch and doing some builds, I still got the mv > error message about 'cannot move' but the make did not fail. Thank you for confirming this. > Perhaps we should change move-if-needed to send the stderr of the mv > -f to /dev/null like we do with cmpprog. I don't think that it is generally useful to hide the error output: in case of a full disk or a real write error, the message can provide valuable help in diagnosing the cause. It can otherwise be very tricky to analyze parallel build failures. I have meanwhile added an improved and fixed version of my proposed patch to the (more complete) gnulib copy of move-if-change. See here: http://thread.gmane.org/gmane.comp.lib.gnulib.bugs/24860/focus=24865 I hereby propose to just import the gnulib copy into GCC and src, http://git.savannah.gnu.org/cgit/gnulib.git/tree/build-aux/move-if-change and document the change in status as below in patches to src/MAINTAINERS and GCC www. (The Autoconf copy of move-if-change has been updated from the gnulib one anyway.) Any reasons against doing so? Thanks, Ralf ChangeLog: 2011-01-28 Ralf Wildenhues * MAINTAINERS (mkinstalldirs): Comes from Automake. (move-if-change): Comes from gnulib. diff --git a/MAINTAINERS b/MAINTAINERS index a471c90..046c5ea 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -38,7 +38,7 @@ config.guess; config.sub; readline/support/config.{sub,guess} binutils@sourceware.org gdb-patches@sourceware.org -depcomp +depcomp; mkinstalldirs Send bug reports and patches to bug-automake@gnu.org. gdb/; readline/; sim/; GDB's part of include/ @@ -69,12 +69,8 @@ ltconfig; ltmain.sh; ltcf-*.sh sources or submitted to the master file maintainer and brought in via a merge. -mkinstalldirs; move-if-change - autoconf: http://gnu.org - Patches to autoconf-patches@gnu.org. - Changes need to be done in tandem with the official AUTOCONF - sources or submitted to the master file maintainer and brought - in via a merge. +move-if-change + Send bug reports and patches to bug-gnulib@gnu.org. symlink-tree gcc: http://gcc.gnu.org Index: codingconventions.html =================================================================== RCS file: /cvs/gcc/wwwdocs/htdocs/codingconventions.html,v retrieving revision 1.62 diff -u -r1.62 codingconventions.html --- codingconventions.html 8 Jan 2011 12:12:42 -0000 1.62 +++ codingconventions.html 28 Jan 2011 20:13:41 -0000 @@ -490,6 +490,11 @@ symlink-tree and ylwrap: These are copied from mainline automake, using automake --add-missing --copy --force-missing. +
  • move-if-change: gnulib hosts this now. The latest version can be +retrieved from +http://git.savannah.gnu.org/cgit/gnulib.git/plain/build-aux/move-if-change. +
    • +
  • Top-level config.rpath: This comes originally from gettext, but gnulib can be considered upstream. The latest version can be retrieved from