[PULL,0/5] Vga 20170901 patches

The following changes since commit 223cd0e13f2e46078d7b573f0b8402bfbee339be:

  Merge remote-tracking branch 'remotes/elmarco/tags/tidy-pull-request' into staging (2017-08-31 15:52:43 +0100)

are available in the git repository at:

  git://git.kraxel.org/qemu tags/vga-20170901-pull-request

for you to fetch changes up to 138bc2df843105edb22978284fc2e16307f16211:

  vga/migration: Update memory map in post_load (2017-09-01 13:52:43 +0200)

----------------------------------------------------------------
qxl: chunked cursor support.
stdvga: bugfixes.

----------------------------------------------------------------

Dr. David Alan Gilbert (1):
  vga/migration: Update memory map in post_load

Gerd Hoffmann (4):
  vga: fix display update region calculation (split screen)
  vga: stop passing pointers to vga_draw_line* functions
  qxl: drop mono cursor support
  qxl: add support for chunked cursors.

 hw/display/vga-helpers.h | 202 ++++++++++++++++++++++++++---------------------
 hw/display/vga_int.h     |   1 +
 hw/display/qxl-render.c  |  45 +++++++----
 hw/display/vga.c         |  16 +++-
 4 files changed, 152 insertions(+), 112 deletions(-)

Hi Gerd,

On 09/01/2017 09:57 AM, Gerd Hoffmann wrote:
> The following changes since commit 223cd0e13f2e46078d7b573f0b8402bfbee339be:
> 
>    Merge remote-tracking branch 'remotes/elmarco/tags/tidy-pull-request' into staging (2017-08-31 15:52:43 +0100)
> 
> are available in the git repository at:
> 
>    git://git.kraxel.org/qemu tags/vga-20170901-pull-request
> 
> for you to fetch changes up to 138bc2df843105edb22978284fc2e16307f16211:
> 
>    vga/migration: Update memory map in post_load (2017-09-01 13:52:43 +0200)
> 
> ----------------------------------------------------------------
> qxl: chunked cursor support.
> stdvga: bugfixes.
> 
> ----------------------------------------------------------------
> 
> Dr. David Alan Gilbert (1):
>    vga/migration: Update memory map in post_load
> 
> Gerd Hoffmann (4):
>    vga: fix display update region calculation (split screen)
>    vga: stop passing pointers to vga_draw_line* functions
>    qxl: drop mono cursor support
>    qxl: add support for chunked cursors.

I'v been reviewing your patches and took some notes but didn't finished, 
since there is something bothering me.
I see they haven't been reviewed yet, can you hold this PR and wait the 
weekend?

Thanks,

Phil.

> 
>   hw/display/vga-helpers.h | 202 ++++++++++++++++++++++++++---------------------
>   hw/display/vga_int.h     |   1 +
>   hw/display/qxl-render.c  |  45 +++++++----
>   hw/display/vga.c         |  16 +++-
>   4 files changed, 152 insertions(+), 112 deletions(-)
>

Hi,

I'v been reviewing your patches and took some notes but didn't
finished, 
> since there is something bothering me.
> I see they haven't been reviewed yet, can you hold this PR and wait
> the 
> weekend?

Ping.  Care to share your concerns?  Weekend is long over ...

cheers,
  Gerd

Hi Gerd,

On 09/07/2017 05:24 AM, Gerd Hoffmann wrote:
>    Hi,
> 
> I'v been reviewing your patches and took some notes but didn't
> finished,
>> since there is something bothering me.
>> I see they haven't been reviewed yet, can you hold this PR and wait
>> the
>> weekend?
> 
> Ping.  Care to share your concerns?  Weekend is long over ...

I apologize it took me so long :/ I had doubts about patches 1 & 2 but 
it could clarify them.

Do you notice performance degradations since patch 2?

Your series is OK, if you ever resend rebased you can add:
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Regards,

Phil.

Hi,

> Do you notice performance degradations since patch 2?

Didn't benchmark it but it has no effect on the vast majority of video
modes in use today.  Basically only the classic vga video modes with
256 colors (or less) will go through the vga render code.

> Your series is OK, 

Good.  Peter, can you pull?

cheers,
  Gerd