Message ID | 20170901112829.2571-13-apahim@redhat.com |
---|---|
State | New |
Headers | show |
Series | scripts/qemu.py fixes and cleanups | expand |
On Fri, 09/01 13:28, Amador Pahim wrote: > A new call to launch() with a running VM will fall in exception and > consequently call shutdown(). > > This patch makes launch() to raise an exception when it's called with VM > already running. > > Signed-off-by: Amador Pahim <apahim@redhat.com> > --- > scripts/qemu.py | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/scripts/qemu.py b/scripts/qemu.py > index 03e4cc34b7..363f649a7e 100644 > --- a/scripts/qemu.py > +++ b/scripts/qemu.py > @@ -165,6 +165,9 @@ class QEMUMachine(object): > Try to launch the VM and make sure we cleanup and expose the > command line/output in case of exception. > ''' > + if self.is_running(): > + raise QEMUMachineError('VM already running') > + > self._iolog = None > self._qemu_full_args = None > try: > -- > 2.13.5 > > Reviewed-by: Fam Zheng <famz@redhat.com>
diff --git a/scripts/qemu.py b/scripts/qemu.py index 03e4cc34b7..363f649a7e 100644 --- a/scripts/qemu.py +++ b/scripts/qemu.py @@ -165,6 +165,9 @@ class QEMUMachine(object): Try to launch the VM and make sure we cleanup and expose the command line/output in case of exception. ''' + if self.is_running(): + raise QEMUMachineError('VM already running') + self._iolog = None self._qemu_full_args = None try:
A new call to launch() with a running VM will fall in exception and consequently call shutdown(). This patch makes launch() to raise an exception when it's called with VM already running. Signed-off-by: Amador Pahim <apahim@redhat.com> --- scripts/qemu.py | 3 +++ 1 file changed, 3 insertions(+)