From patchwork Fri Jan 28 15:04:14 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Wolf X-Patchwork-Id: 80852 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 2E52AB70F1 for ; Sat, 29 Jan 2011 02:04:16 +1100 (EST) Received: from localhost ([127.0.0.1]:56229 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Piprw-0000A6-GE for incoming@patchwork.ozlabs.org; Fri, 28 Jan 2011 10:04:12 -0500 Received: from [140.186.70.92] (port=47693 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PipqY-0008Ed-Iy for qemu-devel@nongnu.org; Fri, 28 Jan 2011 10:02:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PipqT-0006bz-SF for qemu-devel@nongnu.org; Fri, 28 Jan 2011 10:02:46 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33635) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PipqT-0006bq-K1 for qemu-devel@nongnu.org; Fri, 28 Jan 2011 10:02:41 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id p0SF2dnA001706 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 28 Jan 2011 10:02:39 -0500 Received: from dhcp-5-188.str.redhat.com (vpn2-8-185.ams2.redhat.com [10.36.8.185]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p0SF2aKN028625; Fri, 28 Jan 2011 10:02:37 -0500 From: Kevin Wolf To: qemu-devel@nongnu.org Date: Fri, 28 Jan 2011 16:04:14 +0100 Message-Id: <1296227054-13194-1-git-send-email-kwolf@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 Cc: kwolf@redhat.com, geleman@gmail.com Subject: [Qemu-devel] [PATCH] raw-win32: Fix bdrv_flush return value X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Reported-by: TeLeMan Signed-off-by: Kevin Wolf --- Hi TeLeMan, this seems to be the bug that was exposed by the recent qcow2 cache changes. Can you give it a try on a real Windows setup? I have tested it only on Wine so far. Kevin block/raw-win32.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/block/raw-win32.c b/block/raw-win32.c index 06c9710..c204a80 100644 --- a/block/raw-win32.c +++ b/block/raw-win32.c @@ -153,7 +153,7 @@ static int raw_flush(BlockDriverState *bs) int ret; ret = FlushFileBuffers(s->hfile); - if (ret != 0) { + if (ret == 0) { return -EIO; }