[v2,3/5] hdata/i2c: update the list of known i2c devs as of version 2

Message ID 1504163557-14432-4-git-send-email-cclaudio@linux.vnet.ibm.com
State Under Review
Headers show
Series
  • hdata/i2c: add support to i2c array version 2 in P9
Related show

Commit Message

Claudio Carvalho Aug. 31, 2017, 7:12 a.m.
Some i2c devices are not properly identified during the HDAT parsing.

This fixes that by updating the list of known i2c devices as of the i2c
array version 2.

Signed-off-by: Claudio Carvalho <cclaudio@linux.vnet.ibm.com>
---
 hdata/i2c.c | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

Comments

Oliver O'Halloran Sept. 1, 2017, 4:07 a.m. | #1
On Thu, Aug 31, 2017 at 5:12 PM, Claudio Carvalho
<cclaudio@linux.vnet.ibm.com> wrote:
> Some i2c devices are not properly identified during the HDAT parsing.
>
> This fixes that by updating the list of known i2c devices as of the i2c
> array version 2.
>
> Signed-off-by: Claudio Carvalho <cclaudio@linux.vnet.ibm.com>
> ---
>  hdata/i2c.c | 13 +++++++++++--
>  1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/hdata/i2c.c b/hdata/i2c.c
> index bfb5b48..14650b6 100644
> --- a/hdata/i2c.c
> +++ b/hdata/i2c.c
> @@ -91,8 +91,14 @@ struct hdat_i2c_type {
>  };
>
>  struct hdat_i2c_type hdat_i2c_devs[] = {
> +       { 0x1, "gpio", "nxp,pca9551" },
>         /* XXX: Please verify that all VPD EEPROMs are of this type */
> -       { 0x2, "eeprom", "atmel,24c128" }
> +       { 0x2, "eeprom", "atmel,24c128" },
> +       { 0x3, "tpm", "nuvoton,npct650" },
> +       { 0x6, "gpio", "nxp,pca9552" },
> +       { 0x7, "gpio", "nxp,pca9553" },
> +       { 0x8, "gpio", "nxp,pca9554" },
> +       { 0x9, "gpio", "nxp,pca9555" }
>  };
>
>  struct hdat_i2c_label {
> @@ -103,11 +109,14 @@ struct hdat_i2c_label {
>  struct hdat_i2c_label hdat_i2c_labels[] = {
>         { 0x1, "9551-led-controller" },
>         { 0x2, "seeprom" },
> +       { 0x4, "tpm" },
>         { 0x5, "module-vpd" },
>         { 0x6, "dimm SPD" },
>         { 0x7, "proc-vpd" },
>         { 0x8, "sbe-eeprom" },
> -       { 0x9, "planar-vpd" }
> +       { 0x9, "planar-vpd" },
> +       { 0xd, "secure-window-open-gpios" },
> +       { 0xe, "physical-presence-gpios" }
>  };
>
>  /*
> --
> 2.7.4
>

Reviewed-by: Oliver O'Halloran <oohall@gmail.com>

Patch

diff --git a/hdata/i2c.c b/hdata/i2c.c
index bfb5b48..14650b6 100644
--- a/hdata/i2c.c
+++ b/hdata/i2c.c
@@ -91,8 +91,14 @@  struct hdat_i2c_type {
 };
 
 struct hdat_i2c_type hdat_i2c_devs[] = {
+	{ 0x1, "gpio", "nxp,pca9551" },
 	/* XXX: Please verify that all VPD EEPROMs are of this type */
-	{ 0x2, "eeprom", "atmel,24c128" }
+	{ 0x2, "eeprom", "atmel,24c128" },
+	{ 0x3, "tpm", "nuvoton,npct650" },
+	{ 0x6, "gpio", "nxp,pca9552" },
+	{ 0x7, "gpio", "nxp,pca9553" },
+	{ 0x8, "gpio", "nxp,pca9554" },
+	{ 0x9, "gpio", "nxp,pca9555" }
 };
 
 struct hdat_i2c_label {
@@ -103,11 +109,14 @@  struct hdat_i2c_label {
 struct hdat_i2c_label hdat_i2c_labels[] = {
 	{ 0x1, "9551-led-controller" },
 	{ 0x2, "seeprom" },
+	{ 0x4, "tpm" },
 	{ 0x5, "module-vpd" },
 	{ 0x6, "dimm SPD" },
 	{ 0x7, "proc-vpd" },
 	{ 0x8, "sbe-eeprom" },
-	{ 0x9, "planar-vpd" }
+	{ 0x9, "planar-vpd" },
+	{ 0xd, "secure-window-open-gpios" },
+	{ 0xe, "physical-presence-gpios" }
 };
 
 /*